Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Implement PartialEq for DispatchError.#8407

Merged
shawntabrizi merged 1 commit intoparitytech:masterfrom
shaunxw:sw/dispatch-error-equality
Mar 21, 2021
Merged

Implement PartialEq for DispatchError.#8407
shawntabrizi merged 1 commit intoparitytech:masterfrom
shaunxw:sw/dispatch-error-equality

Conversation

@shaunxw
Copy link
Contributor

@shaunxw shaunxw commented Mar 20, 2021

Ignores message field of Module variant in equality comparison.

Closes #8400

@bkchr bkchr added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Mar 20, 2021
@bkchr bkchr requested a review from shawntabrizi March 20, 2021 14:06
@shawntabrizi shawntabrizi added the D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit label Mar 21, 2021
@shawntabrizi
Copy link
Member

bot merge

@ghost
Copy link

ghost commented Mar 21, 2021

Checks failed; merge aborted.

@shawntabrizi
Copy link
Member

bot merge

@ghost
Copy link

ghost commented Mar 21, 2021

Checks failed; merge aborted.

@shawntabrizi shawntabrizi merged commit c731027 into paritytech:master Mar 21, 2021
@shaunxw shaunxw deleted the sw/dispatch-error-equality branch March 21, 2021 05:26
hirschenberger pushed a commit to hirschenberger/substrate that referenced this pull request Apr 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DispatchError changes after encoding and then decoding

4 participants