This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Repot frame_support::traits; introduce some new currency stuff#8435
Merged
Repot frame_support::traits; introduce some new currency stuff#8435
Conversation
gavofyork
added
A0-please_review
2 tasks
6 tasks
gavofyork
changed the title
…e into gav-fungibles-traits
Contributor
|
Why do we need to deprecate Balances pallet? |
Member
Author
|
We don't really. It's a possibility since Assets should be a functionally complete replacement, however I removed the action item since I think Balances will always be a bit faster owing to being able to amalgamate the storage accesses of the system nonce with the balance. |
20 tasks
shawntabrizi
approved these changes
Mar 25, 2021
Member
shawntabrizi
left a comment
shawntabrizi
left a comment
There was a problem hiding this comment.
Note the issues above, but all in all, very good.
| Asset::<T>::get(asset).map(|x| x.supply).unwrap_or_else(Zero::zero) | ||
| } | ||
|
|
||
| fn minimum_balance(asset: Self::AssetId) -> Self::Balance { |
Member
There was a problem hiding this comment.
Returning None here makes sense... It is possible that the fungibles trait should use options?
Contributor
There was a problem hiding this comment.
what will be the difference between no minimum balance vs zero minimum balance?
Member
|
🚀 |
ordian
added a commit
that referenced
this pull request
Mar 31, 2021
* master: (84 commits) Duplicate logging to stdout (#8495) Fix sync restart (#8497) client: fix justifications migration (#8489) helper macro to create storage types on the fly (#8456) Make `BlockImport` and `Verifier` async (#8472) Get rid of `test-helpers` feature in sc-consensus-babe (#8486) Enhancement on Substrate Node Template (#8473) Add Social Network (#8065) Prepare UI tests for Rust 1.51 & new CI image (#8474) Benchmarking pallet-example (#8301) Use pathbuf for remote externalities (#8480) Bring back the on_finalize weight of staking. (#8463) Implement `fungible::*` for Balances (#8454) make types within `generate_solution_type` macro explicit (#8447) [pallet-staking] Refund unused weight for `payout_stakers` (#8458) Use `async_trait` in sc-consensus-slots (#8461) Repot frame_support::traits; introduce some new currency stuff (#8435) Fix &mut self -> &self in add_known_address (#8468) Add NetworkService::add_known_address (#8467) Fix companion check (#8464) ...
hirschenberger
pushed a commit
to hirschenberger/substrate
that referenced
this pull request
Apr 14, 2021
…ytech#8435) * Reservable, Transferrable Fungible(s), plus adapters. * Repot into new dir * Imbalances for Fungibles * Repot and balanced fungible. * Clean up names and bridge-over Imbalanced. * Repot frame_support::trait. Finally. * Make build. * Docs * Good errors * Fix tests. Implement fungible::Inspect for Balances. * Implement additional traits for Balances. * Revert UI test "fixes" * Fix UI error * Fix UI test * Fixes * Update lock * Grumbles * Grumbles * Fixes Co-authored-by: Bastian Köcher <info@kchr.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repots everything from
frame_support::traits. Remains backwards compatible though.Introduces some new traits which should close the gap between the Assets pallet style
Fungiblesand the Balances pallet styleCurrency.TODO:
Tracking issue: paritytech/polkadot-sdk#327