This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Conversation
tomaka
reviewed
Apr 7, 2021
tomaka
approved these changes
Apr 7, 2021
Contributor
tomaka
left a comment
There was a problem hiding this comment.
Not an expert in the sync code, but looks good to me
bkchr
reviewed
Apr 7, 2021
client/network/src/protocol/sync.rs
Outdated
|
|
||
| /// Call when a peer has disconnected. | ||
| pub fn peer_disconnected(&mut self, who: &PeerId) { | ||
| /// Canceled block request may result in |
Member
No, in case of parallel requests, as soon as we download a block all other requests are made obsolete. Normally when doing major sync, we don't issue parallel requests though. Duplicate requests come from issues 1 and 2. We try to download blocks that are already queued, and while the request was active, import queue made some progress. So a call to |
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
bkchr
approved these changes
Apr 7, 2021
hirschenberger
pushed a commit
to hirschenberger/substrate
that referenced
this pull request
Apr 14, 2021
* Drain blocks on peer disconnect * Finish comment * Fixed test * Update client/network/src/protocol/sync.rs Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
jordy25519
pushed a commit
to cennznet/substrate
that referenced
this pull request
Sep 17, 2021
* Drain blocks on peer disconnect * Finish comment * Fixed test * Update client/network/src/protocol/sync.rs Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two issues fixed here: