Upgrade authorship pallet to Frame-v2 by ferrell-code · Pull Request #8663 · paritytech/substrate

ferrell-code · 2021-04-24T03:42:56Z

bumped authorship pallet to framev2 :)

This PR needs a polkadot companion pr to add Authorship to certain mocks construct-runtime!.

The pallet needs to be part of the pallets in construct_runtime to work properly, thus tests might need to be changed.

polkadot companion: paritytech/polkadot#2945

ferrell-code · 2021-04-24T04:17:39Z

relates #7882

ferrell-code · 2021-04-24T04:29:06Z

⚠️ Breaking Change ⚠️

From https://crates.parity.io/frame_support/attr.pallet.html#checking-upgrade-guidelines

storages now use PalletInfo for module_prefix instead of the one given to decl_storage: use of this pallet in construct_runtime! needs careful updating of the name in order to not break storage or to upgrade storage (moreover for instantiable pallet). If pallet is published, make sure to warn about this breaking change.

Hence, users of the Authorship pallet must check name used in construct_runtime!.

name of the pallet in kusama, polkadot and westend are Authorship

frame/authorship/src/lib.rs

ferrell-code · 2021-04-27T03:49:42Z

I believe it needs a polkadot companion pr to add Authorship to certain mocks construct-runtime!

frame/authorship/src/lib.rs

Co-authored-by: Xiliang Chen <xlchen1291@gmail.com>

gui1117

can you put this message #8663 (comment) in the top message

And also add that the pallet needs to be part of the pallets in construct_runtime to work properly, thus tests might need to be changed.

Otherwise it looks good to me, but it needs a companion PR on polkadot

gui1117 · 2021-04-27T10:00:47Z

frame/authorship/src/lib.rs

 			}

-			<Self as Store>::DidSetUncles::put(false);
+			<DidSetUncles<T>>::put(false);


We can still use the trait Store, but I'm fine with the change too.

yeah I realized that after I already changed them ¯_(ツ)_/¯

In general I prefer the syntax like DidSetUncles::<T>::put(false), but its all the same.

kianenigma · 2021-04-28T12:46:05Z

frame/babe/src/mock.rs

 		UncheckedExtrinsic = UncheckedExtrinsic,
 	{
 		System: frame_system::{Pallet, Call, Config, Storage, Event<T>},
+		Authorship: pallet_authorship::{Pallet, Call, Storage, Inherent},


This is not used as far as I can see. If so, You should remove the impl block rather than adding it here.

pallet authorship is used in the equivocation handler (equivocation handler used in the mock requires pallet authorship)

kianenigma · 2021-04-28T12:46:19Z

frame/grandpa/src/mock.rs

 		UncheckedExtrinsic = UncheckedExtrinsic,
 	{
 		System: frame_system::{Pallet, Call, Config, Storage, Event<T>},
+		Authorship: pallet_authorship::{Pallet, Call, Storage, Inherent},


same used for equivocation handler

kianenigma · 2021-04-28T12:47:47Z

frame/staking/src/mock.rs

 		UncheckedExtrinsic = UncheckedExtrinsic,
 	{
 		System: frame_system::{Pallet, Call, Config, Storage, Event<T>},
+		Authorship: pallet_authorship::{Pallet, Call, Storage, Inherent},


it is used in tests to note uncles and check the reward points I think

kianenigma

And also add that the pallet needs to be part of the pallets in construct_runtime to work properly, thus tests might need to be changed.

I'm a bit confused about this, but I suppose it is my mistake. LGTM otherwise.

gui1117 · 2021-04-28T13:12:13Z

And also add that the pallet needs to be part of the pallets in construct_runtime to work properly, thus tests might need to be changed.

I'm a bit confused about this, but I suppose it is my mistake. LGTM otherwise.

pallet which are implemented for a runtime needs to be part of construct_runtime in order to have the pallet info accessible.
Currently it is not enforced by rust code. Maybe we should think about a way to make rust compilation fail when it is not the case.

frame/authorship/src/lib.rs

shawntabrizi · 2021-05-03T02:43:51Z

bot merge

ghost · 2021-05-03T02:43:55Z

Trying merge.

* first commit * get to compile * fix deprecated grandpa * formatting * module to pallet * add authorship pallet to mocks * Fix upgrade of storage. Co-authored-by: Xiliang Chen <xlchen1291@gmail.com> * trigger CI * put back doc Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com> Co-authored-by: Xiliang Chen <xlchen1291@gmail.com>

ferrell-code added 5 commits April 23, 2021 17:35

first commit

6479591

Merge branch 'master' into upgrade-authorship-framev2

284b200

get to compile

b9459a3

fix deprecated grandpa

6e3f133

formatting

e6c58a6

ferrell-code requested a review from andresilva as a code owner April 24, 2021 03:42

module to pallet

5ab5b80

ferrell-code requested a review from kianenigma as a code owner April 24, 2021 06:43

ferrell-code commented Apr 24, 2021

View reviewed changes

frame/authorship/src/lib.rs Show resolved Hide resolved

add authorship pallet to mocks

2e1a245

xlc reviewed Apr 27, 2021

View reviewed changes

frame/authorship/src/lib.rs Outdated Show resolved Hide resolved

gui1117 reviewed Apr 27, 2021

View reviewed changes

frame/authorship/src/lib.rs Outdated Show resolved Hide resolved

Fix upgrade of storage.

4cc2fae

Co-authored-by: Xiliang Chen <xlchen1291@gmail.com>

gui1117 approved these changes Apr 27, 2021

View reviewed changes

gui1117 added A0-please_review Pull request needs code review. B3-apinoteworthy C1-low PR touches the given topic and has a low impact on builders. D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed. labels Apr 27, 2021

ferrell-code mentioned this pull request Apr 27, 2021

Companion for Substrate#8663 paritytech/polkadot#2945

Merged

trigger CI

25bae03

kianenigma reviewed Apr 28, 2021

View reviewed changes

kianenigma approved these changes Apr 28, 2021

View reviewed changes

gui1117 reviewed Apr 28, 2021

View reviewed changes

frame/authorship/src/lib.rs Show resolved Hide resolved

put back doc

6f6ec7e

paritytech deleted a comment Apr 28, 2021

shawntabrizi approved these changes May 3, 2021

View reviewed changes

ghost merged commit c96e57d into paritytech:master May 3, 2021

ferrell-code deleted the upgrade-authorship-framev2 branch May 5, 2021 17:17

This pull request was closed.

Conversation

ferrell-code commented Apr 24, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ferrell-code commented Apr 24, 2021

Uh oh!

ferrell-code commented Apr 24, 2021

⚠️ Breaking Change ⚠️

Uh oh!

Uh oh!

ferrell-code commented Apr 27, 2021

Uh oh!

Uh oh!

Uh oh!

gui1117 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kianenigma left a comment

Choose a reason for hiding this comment

Uh oh!

gui1117 commented Apr 28, 2021

Uh oh!

Uh oh!

shawntabrizi commented May 3, 2021

Uh oh!

ghost commented May 3, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ferrell-code commented Apr 24, 2021 •

edited

Loading