This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Make custom on runtime upgrade prior to pallet ones#8687
Merged
1 commit merged intomasterfrom May 3, 2021
Merged
Conversation
gui1117
added
B3-apinoteworthy
C1-low
Contributor
|
Brilliant |
shawntabrizi
approved these changes
Apr 29, 2021
Member
Yeah, we should do it. |
Contributor
So we want to push for only allowing updates being exposed from the pallet and manually added to the runtime? This is much much better for the scenario of maintaining migration scripts, and potentially making them synced with the pallet version, I also prefer this. If and when we do this, we should also wipe all the temporary storage items that we added for migration versioning and whatnut. |
kianenigma
approved these changes
May 3, 2021
Contributor
Author
|
bot merge |
|
Trying merge. |
ghost
merged commit 
Contributor
|
@sacha-l @jimmychu0807 We need to update substrate.dev accordingly. (here) |
nazar-pc
pushed a commit
to autonomys/substrate
that referenced
this pull request
Aug 8, 2021
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #8683
Breaking change:
All pallets runtime upgrade is now executed after the custom runtime upgrade provided to
Executive.(instead before, frame system pallet runtime upgrade was executed first).
Additional notes
This doesn't deprecated the runtime upgrade of pallets (though I'm also in favor of deprecating them). This can be done in another PR, easiest implementation is just to rename
on_runtime_upgradetodeprecated_on_runtime_upgradefor pallet on runtime upgrade hook.