This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Merged
Conversation
coriolinus
added
A3-in_progress
20 tasks
github-actions
bot
added
A0-please_review
kianenigma
reviewed
May 6, 2021
kianenigma
reviewed
May 6, 2021
kianenigma
reviewed
May 6, 2021
kianenigma
reviewed
May 6, 2021
kianenigma
reviewed
May 6, 2021
kianenigma
approved these changes
May 6, 2021
Contributor
kianenigma
left a comment
kianenigma
left a comment
There was a problem hiding this comment.
Just some minor notes, otherwise looks very good.
shawntabrizi
reviewed
May 6, 2021
Comment on lines
+85
to
+86
| // This looks like an overlapping import/export, but it isn't: | ||
| // macros and traits live in distinct namespaces. |
bkchr
approved these changes
May 7, 2021
Member
bkchr
left a comment
bkchr
left a comment
There was a problem hiding this comment.
Looks good besides the docs that need to be moved and fixed
frame/support/procedural/src/lib.rs
Outdated
| /// ``` | ||
| /// | ||
| /// ```ignore | ||
| /// # // This example is ignored because testing it properly requires imports which would be |
Member
There was a problem hiding this comment.
As with all other macros. Please move the docs to the re-export in frame-support. There you can make this example compile.
Ingnored examples are rather useless as they can break relative fast.
Contributor
Author
|
bot merge |
|
Waiting for commit status. |
ghost
merged commit 
jakoblell
added
D1-audited 👍
nazar-pc
pushed a commit
to autonomys/substrate
that referenced
this pull request
Aug 8, 2021
* impl #[derive(MaxEncodedLen)] for structs * impl #[derive(MaxEncodedLen)] for enums, unions * break long comments onto multiple lines * add doc for public item * add examples to macro documentation * move MaxEncodedLen macro docs, un-ignore doc-tests
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #8719.