This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Merged
Conversation
Contributor
Author
|
Kusama and Polkadot both use |
|
User @ferrell-code, please sign the CLA here. |
KiChjang
added
A0-please_review
KiChjang
reviewed
May 15, 2021
Contributor
KiChjang
left a comment
KiChjang
left a comment
There was a problem hiding this comment.
Mostly just visibility changes and extraneous type parameters, needs verification of the metadata on the pallet however.
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
gui1117
approved these changes
May 19, 2021
Contributor
Author
|
Haven't been free the last week, thanks for the little fixes :), should be good to go now |
KiChjang
approved these changes
May 21, 2021
Contributor
|
bot merge |
|
Trying merge. |
ghost
merged commit 
nazar-pc
pushed a commit
to autonomys/substrate
that referenced
this pull request
Aug 8, 2021
* the great migration * benchmarks to work * unnecessary T: Config * Update frame/multisig/src/lib.rs Co-authored-by: Keith Yeung <kungfukeith11@gmail.com> * Update frame/multisig/src/lib.rs Co-authored-by: Keith Yeung <kungfukeith11@gmail.com> * Update frame/multisig/src/lib.rs Co-authored-by: Keith Yeung <kungfukeith11@gmail.com> * Update frame/multisig/src/lib.rs Co-authored-by: Keith Yeung <kungfukeith11@gmail.com> * Update frame/multisig/src/lib.rs * line width * get to compile Co-authored-by: Keith Yeung <kungfukeith11@gmail.com> Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com>
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relates: #7882
Following the upgrade guidelines here: https://crates.parity.io/frame_support/attr.pallet.html#upgrade-guidelines.
From https://crates.parity.io/frame_support/attr.pallet.html#checking-upgrade-guidelines
So users of the Multisig pallet must be careful about the name they used in
construct_runtime!. Hence the runtime-migration label, which might not be needed depending on the configuration of the Multisig pallet.