This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Merged
Conversation
andresilva
added
A0-please_review
octol
approved these changes
May 13, 2021
tomaka
approved these changes
May 21, 2021
Contributor
Author
|
bot merge |
|
Trying merge. |
ghost
merged commit
nazar-pc
pushed a commit
to autonomys/substrate
that referenced
this pull request
Aug 8, 2021
* grandpa: check for missing data when iterating through authority set changes * grandpa-warp-sync: handle missing data
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#7339 introduced a new client-side auxiliary mapping from
set_id -> block_number, this mapping is used when generating warp sync proofs. Since this code was added recently, nodes that didn't sync from scratch don't have it fully populated, in which case we need to detect it and avoid generating a warp sync proof when we have missing data.