Add support for GrandPa warp sync in the node template#8922
Add support for GrandPa warp sync in the node template#8922tomaka wants to merge 5 commits intoparitytech:masterfrom
Conversation
bkchr
left a comment
There was a problem hiding this comment.
However, I think in general a tutorial would be better.
adoerr
left a comment
There was a problem hiding this comment.
Or at least add a comment, what this is used for and that it is basically optional.
|
The node-template is basically a thousand lines of completely undocumented code that nobody outside of Parity understands, and you want me to write a tutorial or an explanation specifically for these specific 9 lines of code that I'm adding? 😶 |
Fair enough. Those thousand lines of undocumented code probably came into existence by merging one 'it's just those few lines" PR after another. |
The code in the node-template is initially just the same code as the regular node that we have copy-pasted. It has changed very little since then, and is just kept up to date with the rest of the node from time to time. Nobody has ever bothered to document anything because even today we're still not sure about what the API of the service stuff should look like. Everyone agrees that this code should change in a major way, and nobody documents anything because they anticipate that the API will change in a major way anyway. |
|
Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Needs a master merge |
|
Obsoleted by #9284 anyway |
GrandPa warp sync is quite an important protocol nowadays, for both light clients and for #8884.
This PR adds GrandPa warp sync in the node template, as it was missing.