Conversation
shawntabrizi
added
B7-runtimenoteworthy
C1-low
kianenigma
left a comment
kianenigma
left a comment
There was a problem hiding this comment.
+1 on the 75 being a param, otherwise LGTM
Kudos 😎 |
| @@ -2307,19 +2314,29 @@ pub mod pallet { | |||
| let ledger = Self::ledger(&controller).ok_or(Error::<T>::NotController)?; | |||
There was a problem hiding this comment.
Should the origin param for chill_other be configurable for the pallet? (I believe @shawntabrizi mentioned this idea already somewhere)
The current, permission nature of this call is useful for scenarios where we want a network to be continuously "self adjusting". But I think we can imagine scenarios where this makes more sense as a governance only call (that then can be turned into a permission-less call with a runtime upgrade).
While I don't see how it would improve security properties, I think having a call like this go through governance could benefit the community
There was a problem hiding this comment.
Tagential, is it possible to make a call origin configurable without a runtime upgrade?
There was a problem hiding this comment.
Tagential, is it possible to make a call origin configurable without a runtime upgrade?
Nope, that's logic change and needs altering :code.
There was a problem hiding this comment.
+1 on the 75 being a param, otherwise LGTM
+1 :)
Outside the goals of this PR, I am curious if it is worth looking into a governance origin for chill_other; see #9193 (comment)
kianenigma
added
C3-medium
|
bot merge |
|
Trying merge. |
ghost
merged commit 
jakoblell
added
D1-audited 👍
6 participants
When introducing the original staking limits: #8920
we were a bit too strict on the behaviors allowed during otherwise okay scenarios.
The following changes are made in this PR:
chill_otheron a different user.nominate/validatepolkadot companion: paritytech/polkadot#3376