This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Migrate pallet-treasury to the new pallet attribute macro#9197
Merged
9 commits merged intoparitytech:masterfrom Jul 13, 2021
koushiro:migrate-pallet-treasury
Merged
Migrate pallet-treasury to the new pallet attribute macro#91979 commits merged intoparitytech:masterfrom koushiro:migrate-pallet-treasury
pallet-treasury to the new pallet attribute macro#91979 commits merged intoparitytech:masterfrom
koushiro:migrate-pallet-treasury
Conversation
Signed-off-by: koushiro <koushiro.cqx@gmail.com>
Signed-off-by: koushiro <koushiro.cqx@gmail.com>
Contributor
Author
|
@thiolliere @KiChjang PTAL |
gui1117
approved these changes
Jul 12, 2021
Contributor
gui1117
left a comment
gui1117
left a comment
There was a problem hiding this comment.
looks good, polkadot and kusama does use the name Treasury for the name of the pallet, thus no migration needed.
westend and rococo don't have treasury pallet
gui1117
added
A0-please_review
Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com>
Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com>
shawntabrizi
approved these changes
Jul 13, 2021
Member
|
bot merge |
|
Waiting for commit status. |
|
Merge aborted: Checks failed for 5f644dc |
Member
|
bot merge |
|
Trying merge. |
ghost
merged commit 
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #7882
Migrate the
pallet-treasuryto the new pallet attribute macro.From https://crates.parity.io/frame_support/attr.pallet.html#checking-upgrade-guidelines
So users of the pallet must be careful about the name they used in
construct_runtime!. Hence theruntime-migrationlabel, which might not be needed depending on the configuration of the pallet.polkadotandkusamauseTreasuryas pallet name, thus no need for migrationpolkadot companion: paritytech/polkadot#3359