This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Merged
Conversation
emostov
approved these changes
Jul 6, 2021
Contributor
emostov
left a comment
emostov
left a comment
There was a problem hiding this comment.
LGTM
Are there any plans for some migration abstractions that would lend themselves to best practices?
For migrations that go the storage version route there seems to be some easy to miss stuff like this.
Member
Author
shawntabrizi
added
B0-silent
kianenigma
approved these changes
Jul 6, 2021
Member
Author
|
bot merge |
|
Trying merge. |
ghost
merged commit
dvdplm
added a commit
that referenced
this pull request
Jul 6, 2021
* master: fix staking version in genesis (#9280) fix storage info for decl_storage (#9274) Authority_discovery: expose assimilate_storage with GenesisBuild (#9279) Update CODEOWNERS (#9278) Remove in-tree `max-encoded-len` and use the new SCALE codec crate instead (#9163) bump a bunch of deps in parity-common (#9263) Bump linregress due to security vulnerability (#9262) pallet macro: always generate storage info on pallet struct (#9246) Less duplication in test code (#9270) Add `Chilled` event to staking chill extrinsics (#9250)
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When bumping the staking pallet storage from v6 to v7, the genesis version didn't get changed.
This fixes that. New runtimes using the pallet for the first time will have the latest storage version, which is v7.0.0