This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Closed
Conversation
gilescope
commented
Jul 6, 2021
| @@ -1173,7 +1173,7 @@ where | |||
| debug!(target: "afg", "Finding best chain containing block {:?} with number limit {:?}", block, limit); | |||
|
|
|||
Contributor
Author
There was a problem hiding this comment.
just above it's looking for the block so we know it exists.
gilescope
commented
Jul 6, 2021
| block_on(longest_chain_select.finality_target(uninserted_block.hash().clone(), None)) | ||
| .unwrap(), | ||
| ); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
This test didn't really make sense any more.
Contributor
|
There is already #9192 open for this, since it's coming from a community member (and it also was opened first) I'd prefer merging that one instead. I haven't reviewed it yet since I was out, will do. |
Contributor
Author
|
Sorry missed that. Looks like we agree on the changes - their PR LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementes simplification suggested in #9177
I'm in two minds as to whether I like this change or not, so throwing it open to the reviewers.