This repository was archived by the owner on Nov 15, 2023. It is now read-only.
pallet-proxy: emit events on proxy added.#9546
Merged
3 commits merged intoparitytech:masterfrom Aug 25, 2021
Merged
Conversation
xlc
reviewed
Aug 12, 2021
bkchr
added
A0-please_review
gui1117
approved these changes
Aug 16, 2021
Contributor
gui1117
left a comment
gui1117
left a comment
There was a problem hiding this comment.
code is good to me,
maybe this could also be achieve by looking at successful transaction of add_proxy_delegate.
Contributor
Author
|
pls review :] |
bkchr
approved these changes
Aug 25, 2021
Member
|
@shaunxw please run cargo fmt to make the CI happy :P |
Contributor
Author
|
it seems CI is happy with format now |
Contributor
|
bot merge |
|
Trying merge. |
ghost
merged commit 
Wizdave97
pushed a commit
to Wizdave97/substrate
that referenced
this pull request
Aug 25, 2021
* pallet-proxy: emit events on proxy added. * Apply review suggestions.
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.