This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Merged
Conversation
KiChjang
reviewed
Aug 14, 2021
ferrell-code
commented
Aug 14, 2021
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
…e/substrate into fer-bounties-framev2
gui1117
added
A3-in_progress
gui1117
added
A0-please_review
Contributor
Author
|
Not exactly sure how to test if this does indeed migrate the storage correctly, may need a pointer on that |
gui1117
suggested changes
Sep 7, 2021
Contributor
gui1117
left a comment
gui1117
left a comment
There was a problem hiding this comment.
update looks good, but migration is wrong
gui1117
reviewed
Sep 8, 2021
gui1117
reviewed
Sep 9, 2021
gui1117
approved these changes
Sep 9, 2021
Contributor
gui1117
left a comment
gui1117
left a comment
There was a problem hiding this comment.
Looks good to me, I'll test the runtime migration on polkadot/kusama using try-runtime when reviewing the companion
shawntabrizi
approved these changes
Sep 13, 2021
Contributor
|
bot merge |
|
Trying merge. |
ghost
merged commit 
11 tasks
5 tasks
3 tasks
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relates: #7882
Following the upgrade guidelines here: https://crates.parity.io/frame_support/attr.pallet.html#upgrade-guidelines.
From https://crates.parity.io/frame_support/attr.pallet.html#checking-upgrade-guidelines
So users of the
Bountiespallet must be careful about the name they used inconstruct_runtime!. Hence the runtime-migration label, which might not be needed depending on the configuration of theBountiespallet. Since the old version was usingTreasuryin storage, it is probably safe to say all users ofBountiespallet must migrate.PolkadotandKusamaboth use the nameBountiesinconstruct_runtime. They must be both migrated from the current pallet prefix ofTreasury. see companion PRpolkadot companion: paritytech/polkadot#3704