Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Change unhandled Kademlia events from warn to debug#9599

Merged
1 commit merged intomasterfrom
kpp-silent-libp2p-warnings
Aug 20, 2021
Merged

Change unhandled Kademlia events from warn to debug#9599
1 commit merged intomasterfrom
kpp-silent-libp2p-warnings

Conversation

@kpp
Copy link
Contributor

@kpp kpp commented Aug 20, 2021

What does it do?

There is a request from Basti:

2021-08-20 11:21:19 [//Bob] Libp2p => Unhandled Kademlia event: InboundRequestServed { request: FindNode { num_closer_peers: 3 } }
2021-08-20 11:21:19 [//Eve (relay chain)] Libp2p => Unhandled Kademlia event: InboundRequestServed { request: FindNode { num_closer_peers: 3 } }
2021-08-20 11:21:19 [//Charlie (relay chain)] Libp2p => Unhandled Kademlia event: InboundRequestServed { request: FindNode { num_closer_peers: 3 } }
2021-08-20 11:21:19 [//Charlie (relay chain)] Libp2p => Unhandled Kademlia event: InboundRequestServed { request: PutRecord }

These are new events from libp2p we don't handle at the moment. They spam too much so we turn them from warning events into debug.

@kpp kpp added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Aug 20, 2021
@kpp kpp requested review from bkchr and tomaka August 20, 2021 11:55
@tomaka
Copy link
Contributor

tomaka commented Aug 20, 2021

bot merge

@ghost
Copy link

ghost commented Aug 20, 2021

Waiting for commit status.

@ghost ghost merged commit 7ef1c00 into master Aug 20, 2021
@ghost ghost deleted the kpp-silent-libp2p-warnings branch August 20, 2021 12:35
Liao1 pushed a commit to automata-network/substrate that referenced this pull request Sep 16, 2021
@chevdor chevdor mentioned this pull request Sep 23, 2021
s3krit pushed a commit that referenced this pull request Sep 23, 2021
Co-authored-by: Roman <humbug@deeptown.org>
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants