This repository was archived by the owner on Nov 15, 2023. It is now read-only.
state trie inner hashing runtime migration#9671
Closed
cheme wants to merge 132 commits intoparitytech:masterfrom
Closed
state trie inner hashing runtime migration#9671cheme wants to merge 132 commits intoparitytech:masterfrom
cheme wants to merge 132 commits intoparitytech:masterfrom
Conversation
Contributor
Author
|
Re-ping @shawntabrizi or @thiolliere or others about direction taken to evaluate weight in this PR (see TODOs in frame/state-migrate-0-to-1/src/lib.rs). Also in https://github.com/cheme/substrate/blob/bf0aa3d60fef12e37b0f08aaf9e0d1e5563ccbf1/frame/state-migrate-0-to-1/src/lib.rs#L193 (branch where I try to evaluate number of blocks needed to migrate), I did some equivalent weight measurement to what should be configured in polkadot, but I am really not confident with the code I copied. |
Contributor
Author
Contributor
Author
|
cc\ @kianenigma , this is draft PR of migration :) |
Contributor
|
this PR would be more readable if the diff was against #9732 I think |
Contributor
|
might be replaced by #10073 |
Contributor
Author
|
Closing in favor of #10073 |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a follow up of #9732 .
Only change to #9732 is the runtime migration module: cheme/substrate@state-update4-host2...cheme:state-update4-migrationruntime.
The module should be include to the runtime AFTER the chain did switch to hybrid state.
Then in each block a given portion of the state will be rewritten.
When processed, the module could be removed from the next runtime build.
Even if incomplete, I open this as draft, because there is a few points I am not sure how to achieve.
Mostly:
cc\ @thiolliere @shawntabrizi