This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Migrate pallet-session to the new pallet macro#9796
Merged
5 commits merged intoparitytech:masterfrom Sep 28, 2021
koushiro:migrate-session
Merged
Migrate pallet-session to the new pallet macro#97965 commits merged intoparitytech:masterfrom koushiro:migrate-session
pallet-session to the new pallet macro#97965 commits merged intoparitytech:masterfrom
koushiro:migrate-session
Conversation
Signed-off-by: koushiro <koushiro.cqx@gmail.com>
Signed-off-by: koushiro <koushiro.cqx@gmail.com>
gui1117
added
A0-please_review
44 tasks
kianenigma
reviewed
Sep 18, 2021
| use sp_std::prelude::*; | ||
|
|
||
| use super::{shared, Config, IdentificationTuple, ProvingTrie}; | ||
| use crate::{Pallet as SessionModule, SessionIndex}; |
Contributor
There was a problem hiding this comment.
thanks for clearing these up, super::super is super confusing (pun intended).
Contributor
Author
Contributor
|
I wonder if it's okay to just leave |
Contributor
Author
why use declarative macro？I will do it in another PR |
Contributor
|
I meant whether it's okay to not change it in this PR and wait for the next one. But I suppose there isn't any harm in merging this as-is... |
KiChjang
approved these changes
Sep 28, 2021
Contributor
|
bot merge |
|
Trying merge. |
ghost
merged commit 
11 tasks
5 tasks
17 tasks
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #7882
Migrate
pallet-session(excluding historical) to the new pallet attribute macro.From https://crates.parity.io/frame_support/attr.pallet.html#checking-upgrade-guidelines
So users of the pallet must be careful about the name they used in
construct_runtime!. Hence theruntime-migrationlabel, which might not be needed depending on the configuration of the pallet.polkadotandkusamauseSessionas pallet name, thus no need for migration