This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Merged
Conversation
ascjones
added
A0-please_review
ascjones
commented
Sep 29, 2021
| #[pallet::event] | ||
| #[pallet::generate_deposit(pub(super) fn deposit_event)] | ||
| pub enum Event<T: Config> { | ||
| /// Contract deployed by address at the specified address. \[deployer, contract\] |
Contributor
Author
There was a problem hiding this comment.
@jacogr I've removed this \[deployer, contract\], but is that used by polkadot.js currently for the field names?
Contributor
There was a problem hiding this comment.
No, it not used at all - it purely appears in the md documentation generated from the metadata, aka https://polkadot.js.org/docs/.
Member
There was a problem hiding this comment.
You will find this annotations sprinkled everywhere. If moving to this field name syntax, I think we can clean them all up :)
Contributor
There was a problem hiding this comment.
Yes, this was a temporary solution until the events have named fields. More in PR #6684
shawntabrizi
approved these changes
Sep 29, 2021
Contributor
Author
|
bot merge |
|
Trying merge. |
ghost
merged commit
ordian
added a commit
that referenced
this pull request
Oct 2, 2021
* master: (67 commits) Downstream `node-template` pull (#9915) Implement core::fmt::Debug for BoundedVec (#9914) Quickly skip invalid transactions during block authorship. (#9789) Add SS58 prefix for Automata (#9805) Clean up sc-peerset (#9806) Test each benchmark case in own #[test] (#9860) Add build with docker section to README (#9792) Simple Trait to Inspect Metadata (#9893) Pallet Assets: Create new asset classes from genesis config (#9742) doc: subkey usage (#9905) Silence alert about large-statement-fetcher (#9882) Fix democracy on-initialize weight (#9890) Fix basic authorship flaky test (#9906) contracts: Add event field names (#9896) subkey readme update on install (#9900) add feature wasmtime-jitdump (#9871) Return `target_hash` for finality_target instead of an Option (#9867) Update wasmtime to 0.29.0 (#9552) Less sleeps (#9848) remove unidiomatic (#9895) ...
7 tasks
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use struct variants with field names for
Event, instead of unnamed tuple variants. This will be automatically reflected (via theTypeInfoderive) in the metadata with variant fields having names attached.Motivated by my having wasted a lot of time when I mixed up these fields
Instantiated(T::AccountId, T::AccountId)If this is acceptable then we can convert other pallet
Events to this style.