Get account nonce via state_call; remove RPC method#1002
Merged
Conversation
jsdw
changed the title
niklasad1
approved these changes
Jun 7, 2023
Contributor
niklasad1
left a comment
niklasad1
left a comment
There was a problem hiding this comment.
LGTM, I assume the trait bounds are changed because state_call just takes Bytes
Collaborator
Author
Yeah exactly; instead of deserializing form a JSON response we're decoding from a runtime API response :) |
lexnv
approved these changes
Jun 7, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some chains don't have the RPC method that we were using, and using state_call will be more future proof going forwards anyway.
Also make the function public because it's come up a couple of times recently where people have needed to fetch this.