Skip to content

feat(codegen): support NonZero numbers#1012

Merged
jsdw merged 1 commit intoparitytech:masterfrom
gear-tech:cl/non-zero-types
Jun 12, 2023
Merged

feat(codegen): support NonZero numbers#1012
jsdw merged 1 commit intoparitytech:masterfrom
gear-tech:cl/non-zero-types

Conversation

@clearloop
Copy link
Contributor

@clearloop clearloop commented Jun 12, 2023 •
edited
Loading

While changing corresponding field types to NonZeroU64:

The application panicked (crashed).
Message:  Unknown prelude type 'NonZeroU64'
Location: codegen/src/types/type_path.rs:130

Originally from here gear-tech/gear#1838

@clearloop clearloop requested a review from a team as a code owner June 12, 2023 12:30
@cla-bot-2021
Copy link

cla-bot-2021 bot commented Jun 12, 2023

User @clearloop, please sign the CLA here.

jsdw
jsdw approved these changes Jun 12, 2023
View reviewed changes
Copy link
Collaborator

@jsdw jsdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me; thanks for the contribution!

@jsdw jsdw merged commit a62d6a4 into paritytech:master Jun 12, 2023
@clearloop clearloop deleted the cl/non-zero-types branch June 12, 2023 15:40
@clearloop clearloop mentioned this pull request Jun 12, 2023
Closed
@jsdw jsdw mentioned this pull request Jul 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsdw jsdw jsdw approved these changes

+1 more reviewer

@niklasad1 niklasad1 niklasad1 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@clearloop @jsdw @niklasad1