Conversation
|
One thing I still need to gain clarity on is that the I added a wasm test for escda sign/verify anyway so hopefully that will catch any wasm issues there. I also think it's prolly a good idea to have a feature flag to enable each of sr25519 and ecdsa now that there are two impls, so I'll probably also add that before getting this reviewed etc! |
|
The global signing context seems to work fine in WASM, so I switched to using that (as Substrate does when "std" is enabled. I also added feature flags so that people can opt-out of impls they don't need, a check for them in CI and a small doc test |
|
@jsdw Thank you very, very much for taking care of it!
|
|
Thanks for your reply and contribution! That makes sense; I think I'll have a pass over making this crate |
Pushing #1052 over the finish line; thankyou @LGLO for your awesome addition :)