Remove substrate-compat default feature flag

[tadeohepperle]

fixes #1077

I added target_arch = "wasm32" to the jsonrpsee_helpers mod because otherwise jsonrpsee does not expose the client_transport::web module.

[jsdw]

These should be unnecessary shouldn't they? The wasm-rpc-tests crate doesn't expose any features, and so this should have no effect.

[jsdw]

Ooh, putting the feature on a block is much cleaner than my suggesiton; good idea!

I'd suggest hiding these lines though (with a # prefix) and not indenting the rest, since (a) most of it doesn't require that feature and (b) we talk about needing it above anyway, so keeping the example code neater feels better :)

[jsdw]

@tadeohepperle this is the only thing left that I'd like to see done :)

[jsdw]

It might be a slightly better user experience to throw a compile_error if the target isn't wasm32 and jsonrpsee expects that, eg:

#[cfg(all(feature = "jsonrpsee", feature = "web"))]
mod jsonrpsee_helpers {
    #[cfg(not(target_arch = "wasm32")]
    compile_error!("when using jsonrpsee and web features, the target arch must be wasm32");

    // ...
}

So that users know what the issue is if things don't compile properly with these features.

It also self documents for future us why that target_arch is there :)

[jsdw]

🎉

[jsdw]

For the doc errors:

error: unresolved link to `sp_core::Pair`
   --> subxt/src/book/usage/transactions.rs:5:1
    |
5   | / //! # Transactions
6   | | //!
7   | | //! A transaction is an extrinsic that's signed (ie it originates from a given address). The purpose
8   | | //! of extrinsics is to modify the node storage in a deterministic way, and so being able to submit
...   |
210 | | //! [`crate::tx::TxInBlock`] for more options.
211 | | //!
    | |___^
    |
    = note: the link appears in this line:
            
            2. Alternately, Subxt can use instances of Substrate's [`sp_core::Pair`] to sign things by wrapping
                                                                    ^^^^^^^^^^^^^^^
    = note: no item named `sp_core` in scope
    = note: requested on the command line with `-D rustdoc::broken-intra-doc-links`

error: unresolved link to `crate::tx::PairSigner`
   --> subxt/src/book/usage/transactions.rs:5:1
    |
5   | / //! # Transactions
6   | | //!
7   | | //! A transaction is an extrinsic that's signed (ie it originates from a given address). The purpose
8   | | //! of extrinsics is to modify the node storage in a deterministic way, and so being able to submit
...   |
210 | | //! [`crate::tx::TxInBlock`] for more options.
211 | | //!
    | |___^
    |
    = note: the link appears in this line:
            
            them in a [`crate::tx::PairSigner`] (requires the `substrate-compat` feature to be enabled).
                       ^^^^^^^^^^^^^^^^^^^^^^^
    = note: no item named `PairSigner` in module `tx`

error: could not document `subxt`

I guess the best solution is just to remove the [/]'s to stop them being doc links, so the feature isn't required for those docs. We can prolly use cfg flags and such to work around it but it'd get messy!

[jsdw]

Looks good to me!

[lexnv]

LGTM!