Conversation
tadeohepperle
approved these changes
Apr 25, 2023
niklasad1
reviewed
Apr 26, 2023
niklasad1
reviewed
Apr 26, 2023
niklasad1
reviewed
Apr 26, 2023
niklasad1
reviewed
Apr 26, 2023
niklasad1
reviewed
Apr 26, 2023
niklasad1
suggested changes
Apr 26, 2023
Contributor
niklasad1
left a comment
There was a problem hiding this comment.
Great, just remove some unintended committed files and it should be ready to go
Collaborator
Author
|
Comment moved and added files gone :) |
niklasad1
reviewed
Apr 26, 2023
Collaborator
Author
There was a problem hiding this comment.
I debated that; I assume it's used to determine the deps to download for tests so maybe good to keep it to ensure complete consistency between us :)
niklasad1
approved these changes
Apr 26, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move all of our dependencies (and version) to the workspace toml, and reference them in crates where used.
Why?
Note:
package = "parity-scale-codec"is needed in each crate, because the macro uses https://github.com/bkchr/proc-macro-crate, which relies on finding that key in the local TOML (see bkchr/proc-macro-crate#34). The alternative is giving a manual crate path in all uses of the macro, but doesn't seem worth it.