Conversation
niklasad1
approved these changes
Apr 27, 2023
jsdw
approved these changes
Apr 27, 2023
Collaborator
jsdw
left a comment
jsdw
left a comment
There was a problem hiding this comment.
Looks good to me! I'm not sure whether we've covered everything, but looks good offhand and if people run into issues then we can add more impls or whatever :)
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #835.
This PR I implements subxts
Hashertrait for:sp_core::Blake2Hashersp_core::KeccakHasherand subxts
Headertrait for:sp_runtime::generic::HeaderI don't know if there are other types for which I should implement the traits as well, please let me know.