Merged
Conversation
jsdw
commented
May 15, 2023
| } | ||
|
|
||
| /// Hash the given metadata. | ||
| pub fn hash(&self, metadata: &RuntimeMetadataV15) -> [u8; HASH_LEN] { |
Collaborator
Author
There was a problem hiding this comment.
I merged the per pallet hashing and the global hashing here. The effect is that the per pallet hashing will now also care about any additional details that the global one did (eg runtime APIs).
I think that this is the correct behaviour, but worth a ponder as I might be forgetting something :)
lexnv
reviewed
May 15, 2023
lexnv
approved these changes
May 15, 2023
tadeohepperle
approved these changes
May 16, 2023
Contributor
tadeohepperle
left a comment
There was a problem hiding this comment.
Looks good to me :)
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xorinstead ofconcat_and_hash