add #[allow(rustdoc::broken_intra_doc_links)] to subxt-codegen#998
Merged
jsdw merged 3 commits intoparitytech:masterfrom Jun 5, 2023
StackOverflowExcept1on:master
Merged
add #[allow(rustdoc::broken_intra_doc_links)] to subxt-codegen#998jsdw merged 3 commits intoparitytech:masterfrom StackOverflowExcept1on:master
#[allow(rustdoc::broken_intra_doc_links)] to subxt-codegen#998jsdw merged 3 commits intoparitytech:masterfrom
StackOverflowExcept1on:master
Conversation
|
User @StackOverflowExcept1on, please sign the CLA here. |
niklasad1
approved these changes
Jun 4, 2023
jsdw
reviewed
Jun 5, 2023
Collaborator
|
I'm ok with this being added to the codegen since it is likely to be a common case; I just added it to the "main" codegen path, too. |
lexnv
approved these changes
Jun 5, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are developing gear protocol and have decided to enable flag that will convert all warnings to errors when the link in a document comment does not exist.
I think it makes sense to add this attribute in order not to get warnings when building documentation.
The
cargo docwarning looks like this and it comes from the code generated by subxt-codegen