Inner hash of value with new nodes#142
Merged
cheme merged 209 commits intoparitytech:masterfrom Oct 19, 2021
Merged
Conversation
resolving is way more straight forward.
asumption on stored data.
meta for all nodes).
Contributor
Author
|
b7238ef does remove the hybrid specific compact proof encoding. |
gui1117
reviewed
Oct 6, 2021
gui1117
reviewed
Oct 6, 2021
gui1117
reviewed
Oct 6, 2021
gui1117
reviewed
Oct 7, 2021
gui1117
reviewed
Oct 7, 2021
gui1117
reviewed
Oct 13, 2021
gui1117
reviewed
Oct 15, 2021
gui1117
reviewed
Oct 15, 2021
gui1117
approved these changes
Oct 15, 2021
Contributor
gui1117
left a comment
There was a problem hiding this comment.
looks good to me, I didn't understood deeply all algorithm, especially the proof in trie-db/src/proof/
But all changes made sense to me.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims at replacing #134.
It achieves the same goals but always use a new db node when inner hashing is use.
This makes code simpler and can be interesting with rc dbs.
Note that compact proof and compact proof with value iterator did change a bit:
At this point review can be started as all remaining TODOs are minor.
Codec in substrate_like.rs is the same as the one which will be ported in substrate except for the default threshold size (set to 1 here as most of test only use small values).
TODOs
crate versioning
write a test for value removal with prefix (check the value node prefix is correct) + a test that insert twice in triedbmut
63e1651 is related to a possible migration optimisation in state machine, does not really have to be in this PR.
consider running rust format (little care was used here)