Implement compact encoding scheme for partial tries.#44
Merged
Conversation
cheme
reviewed
Dec 5, 2019
Contributor
cheme
left a comment
There was a problem hiding this comment.
Looks good.
I put a few question or suggestion or just general self comment (I will put them in resolve status).
I did play a bit with the pr on jimpo/trie-codec...cheme:try_compact_proof .
I still did not look at the 'Extension' management (I only focused on the branch only case).
| } | ||
| } | ||
| NodePlan::Branch { .. } => { | ||
| if child_prefix.len() <= self.prefix.len() { |
Contributor
There was a problem hiding this comment.
I wonder if we could just debug_assert that (the function is only call with expect).
cheme
approved these changes
Dec 6, 2019
arkpar
approved these changes
Dec 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per module doc: