This repository was archived by the owner on Sep 30, 2021. It is now read-only.
feat: Add proxy.rejectAnnouncement; Update proxy.addProxy and proxy.removeProxy#237
Merged
feat: Add proxy.rejectAnnouncement; Update proxy.addProxy and proxy.removeProxy#237
proxy.rejectAnnouncement; Update proxy.addProxy and proxy.removeProxy#237Conversation
emostov
changed the title
proxy.addProxy and proxy.removeProxyproxy.addProxy and proxy.removeProxy
emostov
changed the title
proxy.addProxy and proxy.removeProxyproxy.rejectAnnouncement; Update proxy.addProxy and proxy.removeProxy
joepetrowski
approved these changes
Sep 3, 2020
Collaborator
joepetrowski
left a comment
joepetrowski
left a comment
There was a problem hiding this comment.
Just a few docs clarifications but looks good.
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
add
proxy.rejectAnnouncementand updatesproxy.addProxyandproxy.removeProxyin order to accurately reflect the updates to the proxy pallet with time delays (see: paritytech/substrate#6770).This was tested manually and below are screen shots from tests: