Skip to content
This repository was archived by the owner on Sep 30, 2021. It is now read-only.

chore(deps): Bump polkadot-js/api from 1.31.2 to 1.34.1 #253

Merged
emostov merged 2 commits into from
Sep 29, 2020
Merged

chore(deps): Bump polkadot-js/api from 1.31.2 to 1.34.1 #253

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b7db1f
chore(deps): Bump polkadot-js/api from 1.31.2 to 1.34.1
emostov Sep 24, 2020
50394ca
Merge origin master
emostov Sep 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions examples/util.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
*/ /** */

import { TRANSACTION_VERSION } from '@polkadot/types/extrinsic/v4/Extrinsic';
import fetch from 'node-fetch';
Copy link
Collaborator

@joepetrowski joepetrowski Sep 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this get imported in this PR but not used?

Copy link
Contributor Author

@emostov emostov Sep 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is used on line 22. I can't figure out exactly why it did not need to be imported before, but while trying out the example it was failing after bumping deps. In modern web browsers fetch is automatically included in the global scope while node does not include it.


import { KeyringPair, OptionsWithMeta } from '../src';
import { createMetadata } from '../src/util';
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
"test": "jest"
},
"dependencies": {
"@polkadot/api": "^1.31.2",
"@polkadot/api": "^1.34.1",
"@types/memoizee": "^0.4.3",
"acorn": ">=7.4.0"
},
Expand Down
2 changes: 1 addition & 1 deletion yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -507,7 +507,7 @@
memoizee "^0.4.14"
rxjs "^6.6.3"

"@polkadot/api@1.34.1", "@polkadot/api@^1.31.2":
"@polkadot/api@1.34.1", "@polkadot/api@^1.34.1":
version "1.34.1"
resolved "https://registry.yarnpkg.com/@polkadot/api/-/api-1.34.1.tgz#c222ac743a427e36dda20a72d95a3a7d83cea094"
integrity sha512-3gCibNRchH+XbEdULS1bwiV1RgarZW1PDw1Y1mAQBVqPrUpkYqntp1D52SQOpAbRzldkwk296Sj+mx9/IeDRXA==
Expand Down