This repository was archived by the owner on Sep 30, 2021. It is now read-only.
fix(types)!: polkadot/api to v4 w. esm; Use substrate/dev for build#404
Merged
fix(types)!: polkadot/api to v4 w. esm; Use substrate/dev for build#404
Conversation
## BREAKING CHANGE
Emitted .js is now es2020, requiring node >= 12.
## Changes
- Use @substrate/dev for build configuration
- new tsconfig.json targets es2019
- prettier is now uses hard tabs and 2 spaces, which causes the huge diff
- some slight type annotations where necessary for claims.ts and method.ts in order to pass the stricter tsconfig
- Babel is now used to transpile the @polkadot/* packages `.js` from ESM to CJS for jest
TarikGul
reviewed
Mar 10, 2021
Co-authored-by: Tarik Gul <47201679+TarikGul@users.noreply.github.com>
dvdplm
approved these changes
Mar 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE
Emitted .js is now es2019, requiring node >= 12.
Changes
.jsfrom ESM to CJS for jest