fix: fix silent overflow in last byte#68
Open
stringhandler wants to merge 1 commit intoparitytech:masterfrom
Open
fix: fix silent overflow in last byte#68stringhandler wants to merge 1 commit intoparitytech:masterfrom
stringhandler wants to merge 1 commit intoparitytech:masterfrom
Conversation
decode::u8, decode::u16, decode::u32, decode::u64 etc, all silently overflow instead of returning Error::Overflow if there is extra data in the last byte decoded. Also added some tests.
dvdplm
approved these changes
Sep 18, 2023
dvdplm
left a comment
dvdplm
left a comment
There was a problem hiding this comment.
Looks good to me, seems like an important safety check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
decode::u8,decode::u16,decode::u32,decode::u64etc, all silently overflow instead of returning Error::Overflow if there is extra data in the last byte decoded.Also added some tests.