Skip to content

Add callback parameter LoginUIButtonManager.Login() method, remove commented, remove cc variable and it's logic codes #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jongfeel wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add callback parameter LoginUIButtonManager.Login() method, remove commented, remove cc variable and it's logic codes #68

jongfeel wants to merge 1 commit into from

Conversation

@jongfeel
Copy link
Collaborator

@jongfeel jongfeel commented Jun 13, 2023

Review point

  • Login() 메소드에 대해 isSigned라는 callback을 받게 하고 로직 처리하게 변경
  • cc 변수와 그 관련된 분기처리 코드 삭제
  • 기타 주석 코드 삭제 등

코드 리뷰 진행과 동시에 수정된 코드 checkout을 하시고 확인한 후에 login 처리가 될 것 같으면 merge 진행하시면 될 것 같습니다.

@jongfeel
Add callback parameter LoginUIButtonManager.Login() method, remove co…
a6fca3f 
…mmented, remove cc variable and it's logic codes
@jongfeel jongfeel added the bug Something isn't working label Jun 13, 2023
@jongfeel jongfeel requested a review from park7628 June 13, 2023 07:20
@jongfeel jongfeel self-assigned this Jun 13, 2023
@jongfeel jongfeel linked an issue Jun 13, 2023 that may be closed by this pull request
Firebase로그인 과정에서의 데이터 전달에 관한 질문입니다. #67
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@park7628 park7628 Awaiting requested review from park7628

Assignees

@jongfeel jongfeel

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Firebase로그인 과정에서의 데이터 전달에 관한 질문입니다.

2 participants

@jongfeel