Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
병합 확인 #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
병합 확인 #19
Changes from all commits
6303fdc7852209b9229e1f163cd60940c5d75ed443b0d3b715af66d7d9a436385b895eda0fcce01a84e53378f3fb12f6311a1e8b9609c361b3c314aee57d69File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue (bug_risk): The _issue_recovery_token function now references expires_at without defining it, which will raise a NameError at runtime.
The previous
expires_at = datetime.utcnow() + timedelta(minutes=10)line was removed butexpires_atis still returned, so the first call to_issue_recovery_tokenwill raise aNameError. Please reintroduce theexpires_atassignment (preferably usingdatetime.now(timezone.utc)for timezone awareness) before the return statement.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue (bug_risk): _purge_expired_password_recovery_sessions uses now but no longer defines it, leading to a NameError.
In
_purge_expired_password_recovery_sessions,nowwas removed but is still referenced in the comprehension (session_state.get("expires_at") <= now), which will cause aNameError. Definenowagain before buildingexpired_tokens(e.g.,now = datetime.now(timezone.utc)).Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.