Merged
Conversation
Haniyya
suggested changes
Mar 2, 2018
lib/json/schema_builder/entity.rb
Outdated
| end | ||
|
|
||
| def extend(child_name, &block) | ||
| child = children.find { |c| c.name == child_name.to_sym } |
There was a problem hiding this comment.
@parrish I think it would be useful to extract this into its own method.
object_with_child.child(:type) #=> ObjectBuilder<:type> Not sure about the name yet, but this way you could pass children easily to other functions as well.
There was a problem hiding this comment.
Maybe it would be enough to just return the child from extend if !block_given?
|
Otherwise this looks really good. And it's nice that the actual changes are so small. 👍 |
This triggers schema reinitialization when entities are added after initialization. Towards #4.
97b12bb to
90e16e4
Compare
Owner
Author
|
@Haniyya |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows schemas to be built iteratively for #4:
Also allows schema entities to reopen and modify children with
extend(name):To replace a child entity, just redefine it: