Skip to content

Conversation

@pbrobles
Copy link

@pbrobles pbrobles commented Nov 13, 2023

INFRA-2675

  • The PR adds build-publish.yml and ci-test.yml, improving the project's continuous integration process.
  • adapter_test.go: Changes were implemented to address failing tests. Initially, the NewModel function from the casbin/model package was used to create a new model instance, which caused issues in the enforcement logic. To resolve this, the model instantiation was changed to make(model.Model), a more direct and error-free approach to create a model instance. Additionally, the enforcement call e.Enforce(sub, obj, act) was updated to handle its return values correctly, ensuring proper error handling and test execution.

@parsable-sjwoodr
Copy link

@pbrobles pbrobles requested a review from SethO November 13, 2023 23:22
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@pbrobles pbrobles merged commit ed5bb39 into master Nov 15, 2023
@pbrobles pbrobles deleted the infra-2675-buid-gha-pipeline branch November 15, 2023 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants