Add context to object save in JS SDK#730
Conversation
* commit 'e129790ed587819ecfcaed59fc7ff90ec6ffcfa1': (84 commits) Add `cascadeSave` option in ParseObject to JS docs (parse-community#664) Update apple sign in documentation (parse-community#662) Bump mixin-deep from 1.3.1 to 1.3.2 (parse-community#670) Update GraphQL docs with latest changes (parse-community#669) remove a bunch of parse cloud references (parse-community#654) docs: fixed examples for pipeline in aggregation (parse-community#661) Add beta notice to the GraphQL Guide (parse-community#659) iOS Documentation Revamp (parse-community#650) Fix doc for creating a subscription in javascript (parse-community#658) GraphQL Customisation (parse-community#652) added PhantAuth authData docs (parse-community#655) Fix typo in keys.md (parse-community#656) Fix typo in cloud-code.md (parse-community#657) add reference to afterFind, add more detail on predefined classes (parse-community#653) Add `keys` and `excludeKeys` options to REST docs (parse-community#649) document push type and priority keys for notifications (parse-community#639) Documentation for Sign In With Apple (parse-community#648) Documentation for isDataAvailable (parse-community#647) Remove line for 3.x (parse-community#646) Add documentation for query.withCount (parse-community#645) ...
* commit 'cc489df4a3d8544a52148c079ecaee3d1762108d': Adding microsoft oauth doc (parse-community#698) Encrypting Current User and Local Storage (parse-community#695) Update live-query.md (parse-community#696) Update config.md (parse-community#689) Fix User Subclass Documentation (parse-community#690) remove info about parse.com compatibility (parse-community#686)
TomWFox
left a comment
TomWFox
left a comment
There was a problem hiding this comment.
Looks good, one wee suggestion.
Also, I think it would be worth including this in the cloud code guide too. You could link to the content in the JS guide or vice versa but considering it’s a relatively small section I would just copy and paste it in.
Co-Authored-By: Tom Fox <13188249+TomWFox@users.noreply.github.com>
- added headings per trigger group - moved context of save triggers into own section
|
The first thing I think of before starting a PR is "Which changes in the docs would make Tom happy?" 😌 |
|
❤️ I think I might actually make a bot that comments that on every PR to a Parse repo 😅😝 |
|
Good point, we don’t have a guideline for this but probably should. When there is a clear section for a new feature in the docs I think it makes sense to add a note, like in some sections of the Cloud Code guide... I’ve been bitten by this when I was trying to use request context only to realise that it wasn’t included in the version I was running. |
|
Yes, I also found some of these:
|
- Insert version before merging
|
Uh, I lost track of that one, thanks @TomWFox |
|
No probs, me too! |
2 participants
Added description for new feature to expose Cloud Code trigger context in
Parse.Object.save().Don't merge until