fix(Database Browser): Avoid Parse transformations on array and object fields#1223
Merged
dplewis merged 2 commits intoparse-community:masterfrom Aug 15, 2019
Conversation
…t fields Fixes parse-community#983 When rendering/editing `Array` or `Object` type fields on `Database Browser`, we must avoid any transformations of generic data to the `ParseObject` format. Since these fields are generic, we can't assume it will contain Parse related content.
davimacedo
approved these changes
Aug 14, 2019
Member
davimacedo
left a comment
davimacedo
left a comment
There was a problem hiding this comment.
@douglasmuraoka thanks for tackling this! I tested here and it seems working pretty fine to me.
@dplewis do you want to also take a look on this? It should:
close #984
close #983
Member
|
I’ll pull it down now |
douglasmuraoka
deleted the
fix_avoid_generic_array_objects_transformations
branch
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #983
Fixes #285
When rendering/editing
ArrayorObjecttype fields onDatabase Browser, we must avoid any transformations of generic data to theParseObjectformat. Since these fields are generic, we can't assume it will contain Parse related content.