fix: Avoid filter tab disappears on apply filter#1229
fix: Avoid filter tab disappears on apply filter#1229davimacedo merged 6 commits intoparse-community:masterfrom
Conversation
|
@mtrezza do you mind to give it a try and let us know if it solves the issue? |
|
I’ll check it out. |
|
@alencarlucas I've tried it out and it seems working fine. I have just one additional question. Is it possible to dismiss the menu when clicking outside the box? Thanks! |
|
@alencarlucas if you want external click see |
|
@dplewis 517ae29 doesn't work properly on the filter tab 'cause when you click on the dropdown to select a column or an operator the popover component understand it as an external click too and close the tab. The dropdown has an absolute position and doesn't render inside the popover wrapper. Anyway, I'll tackle this one today and find a good solution to this. |
|
@davimacedo @dplewis Fixed. I changed the checkExternalClick method on popover component to check the popoverWrapper instead of popoverLayer, to avoid closing on click in the dropdown element. |
* commit '54ce71875033d8c3309d4f18090ac8336795d4de': (54 commits) 2.0.1 (parse-community#1264) 2.0.0 (parse-community#1263) Update cross-env to the latest version 🚀 (parse-community#1262) Update query-string to the latest version 🚀 (parse-community#1261) Update path-to-regexp to the latest version 🚀 (parse-community#1260) Update sass-loader to the latest version 🚀 (parse-community#1254) fix(Database Browser): Cell edit not updating partial view (parse-community#1255) Update eslint to the latest version 🚀 (parse-community#1259) Update commander to the latest version 🚀 (parse-community#1257) Update eslint-plugin-jest to the latest version 🚀 (parse-community#1256) Update graphql to the latest version 🚀 (parse-community#1253) refactor(Database Browser): Table performance improvements (parse-community#1241) Update parse to the latest version 🚀 (parse-community#1252) Update webpack to the latest version 🚀 (parse-community#1251) build(deps): bump eslint-utils from 1.4.0 to 1.4.2 (parse-community#1249) Update babel-eslint to the latest version 🚀 (parse-community#1245) fix: Avoid filter tab disappears on apply filter (parse-community#1229) Update graphql to the latest version 🚀 (parse-community#1243) Update graphql to the latest version 🚀 (parse-community#1242) Update graphql to the latest version 🚀 (parse-community#1240) ... # Conflicts: # package-lock.json
4 participants
ref #1140