Prevent the duplicate last entry when sorting by _createdAt#1334
Merged
acinader merged 3 commits intoparse-community:masterfrom Oct 17, 2019
Merged
Prevent the duplicate last entry when sorting by _createdAt#1334acinader merged 3 commits intoparse-community:masterfrom
acinader merged 3 commits intoparse-community:masterfrom
Conversation
This should prevent the duplicate last entry issue parse-community#1309
Member
|
@W0lfw00d It looks good to me. Can you provide details on how to replicate the issue? |
Contributor
Author
|
Basically have more row than can during the initial load (40 for example) and check the length of (and the bottom two rows will be identical) |
Merged
dplewis
approved these changes
Oct 17, 2019
Member
dplewis
left a comment
dplewis
left a comment
There was a problem hiding this comment.
Good catch! I had multiple duplicates and this fixes it.
beiguancyc
pushed a commit
to beiguancyc/parse-dashboard
that referenced
this pull request
Oct 18, 2019
* parse: (36 commits) prepare for 2.0.4 (parse-community#1347) Only do a complex query for createdAt instead of -createdAt (parse-community#1334) Update parse to the latest version 🚀 (parse-community#1345) Update webpack to the latest version 🚀 (parse-community#1344) Update core-js to the latest version 🚀 (parse-community#1343) Update core-js to the latest version 🚀 (parse-community#1342) Update core-js to the latest version 🚀 (parse-community#1341) Update eslint-plugin-jest to the latest version 🚀 (parse-community#1340) Update eslint-plugin-jest to the latest version 🚀 (parse-community#1339) Update webpack to the latest version 🚀 (parse-community#1338) Update babel7 to the latest version 🚀 (parse-community#1337) Fixed incorrect links to PR details (parse-community#1329) Update babel7 to the latest version 🚀 (parse-community#1335) Update eslint-plugin-react to the latest version 🚀 (parse-community#1327) Update react to the latest version 🚀 (parse-community#1326) Update cross-env to the latest version 🚀 (parse-community#1324) This should resolve parse-community#1297. The objectId was missing from the filter list. (parse-community#1315) Update eslint-plugin-react to the latest version 🚀 (parse-community#1322) Update cross-env to the latest version 🚀 (parse-community#1321) Update eslint-plugin-react to the latest version 🚀 (parse-community#1319) ... # Conflicts: # package-lock.json
douglasmuraoka
added a commit
to douglasmuraoka/parse-dashboard
that referenced
this pull request
Dec 24, 2019
After parse-community#1334, the infinite scroll is no longer loading the next set of objects. This commit undoes parse-community#1334, and tries another approach in order to fix the original problem.
This was referenced Dec 24, 2019
acinader
pushed a commit
that referenced
this pull request
Dec 24, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only do a complex query for
createdAtinstead of-createdAtThis should resolve this issue: #1309