refactor: update svgprep plugin for webpack 5#1859
Merged
mtrezza merged 2 commits intoparse-community:alphafrom Oct 13, 2021
Merged
refactor: update svgprep plugin for webpack 5#1859mtrezza merged 2 commits intoparse-community:alphafrom
mtrezza merged 2 commits intoparse-community:alphafrom
Conversation
Thanks for opening this pull request!
|
Member
|
It builds fine, please again let me know when this is ready for review. |
Contributor
Author
|
@mtrezza It is ready 👍 |
mtrezza
approved these changes
Oct 13, 2021
Member
mtrezza
left a comment
There was a problem hiding this comment.
Looks good! Another annoying deprecation message less is candy for the eye!
Contributor
|
🎉 This pull request has been released in version 3.3.0-alpha.5 |
Contributor
|
🎉 This change has been released in version 3.3.0-beta.1 |
Contributor
|
🎉 This change has been released in version 3.3.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Pull Request Checklist
Issue Description
This PR updates the SVG Prep plugin for webpack 5 as the current version throws the following warning:
Related issue: #1859
Approach
processAssetshook instead ofemit.tapAsyncwithtapPromiseto simplify the code withasync/await.compilationprocess.!!name.match(/\.svg$/)withname.endsWith('.svg')to make it easier to understand how the array is filtered.compilation.emitAssetinstead of just putting new objects intocompilation.assetswhich was the old way (pre-webpack 5) of emitting new assets.RawSourceto letwebpack-sourceshandle the final format (which usually is an object withsourceandsizeproperties).TODOs before merging