refactor: remove unused dependencies#1905
refactor: remove unused dependencies#1905damianstasik wants to merge 2 commits intoparse-community:alphafrom
Conversation
Thanks for opening this pull request!
|
| "react-router-dom": "5.3.0", | ||
| "regenerator-runtime": "0.13.8", | ||
| "semver": "7.3.4", | ||
| "typescript": "4.4.3" |
There was a problem hiding this comment.
@mtrezza could you specify what is using typescript? I checked the repo and there is no configuration for TS, there are no .tsx? files and no build set up for TS 🤔
There was a problem hiding this comment.
madge uses it; even if you don't see any reference for a dependency in the code base, another dependency may require it based on its configuration.
There was a problem hiding this comment.
@mtrezza I checked the report madge generates and everything works.
even if you don't see any reference for a dependency in the code base, another dependency may require it based on its configuration.
Yeah, I get that, I wouldn't try to send the PR otherwise. I checked peer deps of other packages before to be sure if TS is really not required.
There was a problem hiding this comment.
|
Could you please resolve the conflict? |


New Pull Request Checklist
Issue Description
Both
typescriptandbabel-plugin-transform-object-rest-spreadare not used anywhere, there is no need to keep them.Related issue: #1902
Approach
TODOs before merging