Added 'route' config option for mounting dashboard#215
Closed
mamaso wants to merge 2 commits intoparse-community:masterfrom
Closed
Added 'route' config option for mounting dashboard#215mamaso wants to merge 2 commits intoparse-community:masterfrom
mamaso wants to merge 2 commits intoparse-community:masterfrom
Conversation
|
By analyzing the blame information on this pull request, we identified @drew-gross, @flovilmart and @bgw to be potential reviewers. |
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
|
@mamaso updated the pull request. |
Contributor
|
I have a less intrusive solution in the making |
Contributor
|
see #217, I just came back home and pushed it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a 'route' property to the parse-dashboard-config will now run the dashboard on that route.
@flovilmart If you have a chance to play around with this I'd appreciate it. You'll see most functionality works, but in developer tools there are requests which seem to be failing due to some root relative '/apps/' urls. I'd love to find a better solution than changing all the root relative '/apps/' to 'apps/'.