Skip to content

fix: Info panel not configurable via new ParseDashboard() when running as express middleware#2639

Merged
mtrezza merged 2 commits intoparse-community:alphafrom
vardhan0604:bug/2638
Jan 29, 2025
Merged

fix: Info panel not configurable via new ParseDashboard() when running as express middleware#2639
mtrezza merged 2 commits intoparse-community:alphafrom
vardhan0604:bug/2638

Conversation

@vardhan0604
Copy link
Copy Markdown
Contributor

@vardhan0604 vardhan0604 commented Jan 28, 2025 •
edited
Loading

New Pull Request Checklist

Issue Description

Closes: #2638

Approach

TODOs before merging

  • Add tests
  • Add changes to documentation (guides, repository pages, in-code descriptions)

@parse-github-assistant
Copy link
Copy Markdown

parse-github-assistant Bot commented Jan 28, 2025 •
edited
Loading

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@uffizzi-cloud
Copy link
Copy Markdown

uffizzi-cloud Bot commented Jan 28, 2025

Uffizzi Ephemeral Environment deployment-60366

⌚ Updated Jan 28, 2025, 17:21 UTC

☁️ https://app.uffizzi.com/github.com/parse-community/parse-dashboard/pull/2639

📄 View Application Logs etc.

What is Uffizzi? Learn more

@vardhan0604
Copy link
Copy Markdown
Contributor Author

vardhan0604 commented Jan 28, 2025

Hey @mtrezza, could you please review this PR? Thanks!

@mtrezza
Copy link
Copy Markdown
Member

mtrezza commented Jan 28, 2025

@vardhan0604 is this really all or are there commits missing in this PR?

@vardhan0604
Copy link
Copy Markdown
Contributor Author

vardhan0604 commented Jan 28, 2025 •
edited
Loading

Yeah@mtrezza, I tried it, and this fixed the issue. Can you review it locally??

@mtrezza
Copy link
Copy Markdown
Member

mtrezza commented Jan 28, 2025

I'll review, but could you explain what effect this change has? What's the purpose of this line, are there maybe any other side effects?

@vardhan0604
Copy link
Copy Markdown
Contributor Author

vardhan0604 commented Jan 29, 2025

I'll review, but could you explain what effect this change has? What's the purpose of this line, are there maybe any other side effects?

This change was originally introduced in PR #2584. The setBasePath() function updates the base path, but in this case, it wasn’t actually necessary. While it worked fine when a config file was present, it caused issues when used as an Express middleware. Removing it prevents unintended base path changes in that scenario.

Let me know if you need further clarification!

@mtrezza mtrezza changed the title fix: Info panel not configurable via options fix: Info panel not configurable via options when running as express middleware Jan 29, 2025
@mtrezza mtrezza changed the title fix: Info panel not configurable via options when running as express middleware fix: Info panel not configurable via new ParseDashboard() when running as express middleware Jan 29, 2025
@mtrezza mtrezza merged commit a9b8cd4 into parse-community:alpha Jan 29, 2025
parseplatformorg pushed a commit that referenced this pull request Jan 29, 2025
@semantic-release-bot
chore(release): 6.0.0-alpha.22 [skip ci]
e06e577 
# [6.0.0-alpha.22](6.0.0-alpha.21...6.0.0-alpha.22) (2025-01-29)

### Bug Fixes

* Info panel not configurable via `new ParseDashboard()` when running as express middleware ([#2639](#2639)) ([a9b8cd4](a9b8cd4))
@parseplatformorg
Copy link
Copy Markdown
Contributor

parseplatformorg commented Jan 29, 2025

🎉 This change has been released in version 6.0.0-alpha.22

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Jan 29, 2025
parseplatformorg pushed a commit that referenced this pull request Mar 4, 2025
@semantic-release-bot
chore(release): 6.1.0 [skip ci]
d875f44 
# [6.1.0](6.0.0...6.1.0) (2025-03-04)

### Bug Fixes

* Info panel Cloud Code call is unauthenticated without using master key ([#2641](#2641)) ([e879e4f](e879e4f))
* Info panel Cloud Code call sends `objectId` instead of `Parse.Object` ([#2643](#2643)) ([a4bcabc](a4bcabc))
* Info panel item `panel` calls Cloud Code with parameter `objectId` instead of `Parse.Object` and without `masterKey` ([#2649](#2649)) ([884ff70](884ff70))
* Info panel not configurable via `new ParseDashboard()` when running as express middleware ([#2639](#2639)) ([a9b8cd4](a9b8cd4))
* Info panel not showing when some apps miss infoPanel config ([#2627](#2627)) ([539e883](539e883))
* Node 22 support missing in package.json ([#2617](#2617)) ([8c07284](8c07284))
* Security upgrade cross-spawn from 7.0.3 to 7.0.6 ([#2629](#2629)) ([47a43e0](47a43e0))
* Security upgrade express from 4.21.0 to 4.21.1 ([#2607](#2607)) ([54bf0af](54bf0af))
* Security upgrade node from 20.17.0-alpine3.20 to 20.18.2-alpine3.20 ([#2647](#2647)) ([44df723](44df723))
* Security upgrade ws, parse and puppeteer ([#2618](#2618)) ([bab71dc](bab71dc))

### Features

* Add cell selection in data browser on space bar touch down ([#2661](#2661)) ([9d623a9](9d623a9))
* Add dynamic master key by allowing to set option `masterKey` to a function ([#2655](#2655)) ([9025ed0](9025ed0))
* Add info panel `keyValue` item parameter `isRelativeUrl` to link to dashboard pages ([#2646](#2646)) ([6389fc6](6389fc6))
* Add info panel item `panel` to load and display data on demand ([#2622](#2622)) ([8e5741d](8e5741d))
@parseplatformorg
Copy link
Copy Markdown
Contributor

parseplatformorg commented Mar 4, 2025

🎉 This change has been released in version 6.1.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

state:released Released as stable version state:released-alpha Released as alpha version

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Info panel not configurable via options

3 participants

@vardhan0604 @mtrezza @parseplatformorg