fix: Calculated value drop-down in menu bar overlaps with info panel buttons

[mtrezza]

New Pull Request Checklist

• I am not disclosing a vulnerability.
• I am creating this PR in reference to an issue.

Summary by CodeRabbit

• New Features

  • Footer now shows selectable statistics (Sum, Mean, Count, Min, Max, P99) for selected cells.
  • Selected cell count is displayed in the footer.

• Style

  • Statistics UI moved from the toolbar into a compact footer popover with new styling and interactions.

• Chores

  • Toolbar no longer shows the previous stats UI.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[parse-github-assistant]

🚀 Thanks for opening this pull request! We appreciate your effort in improving the project. Please let us know once your pull request is ready for review.

[parseplatformorg]

✅ Snyk checks have passed. No issues have been found so far.

Status	Scanner	Critical	High	Medium	Low	Total (0)
✅	Open Source Security	0	0	0	0	0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

[coderabbitai]

Warning

Rate limit exceeded

@mtrezza has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 21 minutes and 29 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 19608ee and 09e5f66.

📒 Files selected for processing (1)

• src/dashboard/Data/Browser/FooterStats.react.js

📝 Walkthrough

Walkthrough

Moved the in-toolbar statistics UI into a new FooterStats component in the Browser footer: Toolbar no longer manages stats or accepts selectedData; Browser now tracks selectedCellsCount and selectedData, receives cell selection callbacks from DataBrowser, and passes data to BrowserFooter/FooterStats.

Changes

Cohort / File(s)	Change Summary
Toolbar cleanup src/components/Toolbar/Toolbar.react.js, src/components/Toolbar/Toolbar.scss	Removed internal Stats component, related imports (Popover, Position), event handlers, state, conditional rendering and removed selectedData from Toolbar.propTypes; deleted associated SCSS rules.
Browser state & wiring src/dashboard/Data/Browser/Browser.react.js, src/dashboard/Data/Browser/BrowserFooter.react.js	Added selectedCellsCount and selectedData state to Browser; added and bound handleCellSelectionChange; pass onCellSelectionChange to DataBrowser; BrowserFooter now accepts selectedCellsCount and selectedData and conditionally renders FooterStats.
DataBrowser / Toolbar prop changes src/dashboard/Data/Browser/DataBrowser.react.js, src/dashboard/Data/Browser/BrowserToolbar.react.js	DataBrowser now invokes onCellSelectionChange(count, selectedData) on selection changes; removed selectedData prop from BrowserToolbar and its forwarding to Toolbar.
New footer stats UI src/dashboard/Data/Browser/FooterStats.react.js, src/dashboard/Data/Browser/FooterStats.scss	Added FooterStats component (metric definitions: Sum, Mean, Count, Min, Max, P99), formatting utility, popover metric selector with localStorage persistence, and new SCSS for popover/trigger styles and animations.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant DataBrowser
    participant Browser
    participant BrowserFooter
    participant FooterStats

    User->>DataBrowser: Selects cells in grid
    DataBrowser->>Browser: onCellSelectionChange(count, selectedData)
    Browser->>Browser: setState(selectedCellsCount, selectedData)
    Browser->>BrowserFooter: props selectedCellsCount, selectedData
    BrowserFooter->>FooterStats: render with selectedData
    FooterStats->>FooterStats: compute metric value (sum/mean/...)
    FooterStats->>User: show metric value and popover controls

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

• fix: Info panel may show stale data of previous objects when refreshing the data table or navigating between classes #3036: Modifies DataBrowser selection-related logic and state updates—closely related to onCellSelectionChange and selection propagation.
• fix: Right-click on info panel header selects the object #3082: Changes DataBrowser selection handling (guards/header click behavior), intersects with selection flow changes introduced here.
• feat: Add Settings menu to scroll info panel to top when browsing through rows #2937: Alters BrowserToolbar props (adds/removes toolbar props); relevant because this PR removes selectedData from BrowserToolbar/Toolbar.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The PR description only contains the contributor checklist without addressing required template sections like 'Issue Description' and 'Approach', leaving critical details about the fix and implementation approach missing.	Fill in the 'Closes' field with the referenced issue number, add a clear description of the overlap issue and the implemented solution, and document the approach taken to resolve it.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title describes fixing an overlap issue with a calculated value drop-down, which directly aligns with the PR's main objective of resolving UI layout conflicts.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 2

🤖 Fix all issues with AI agents

In `@src/dashboard/Data/Browser/FooterStats.react.js`:
- Around line 118-122: The catch block around localStorage.setItem(STORAGE_KEY,
item.type) currently declares an unused parameter `e`, causing a lint error;
update the catch clause to remove the unused parameter (use `catch { ... }`) so
the block silently handles the exception, keeping the code around
localStorage.setItem and STORAGE_KEY unchanged.
- Around line 79-81: The catch block in FooterStats.react.js declares an unused
parameter `e`, causing a lint error; remove the unused parameter by changing the
catch clause to a parameterless catch (i.e., use `catch { ... }`) and keep the
existing comment about localStorage not being available so behavior is
unchanged; update the catch that currently references `e` in the FooterStats
component to use the parameterless form.

🧹 Nitpick comments (1)

src/dashboard/Data/Browser/FooterStats.react.js (1)

15-29: Consider handling Infinity values for edge case robustness.

Infinity and -Infinity pass the current validation since typeof Infinity === 'number' and !isNaN(Infinity). If Math.min() or Math.max() is called on an empty array, they return Infinity/-Infinity respectively, which would display literally.

While the parent component likely guards against empty data, adding a check improves defensive coding.

Suggested improvement

 const formatNumber = (value, isCount = false) => {
-  if (typeof value !== 'number' || isNaN(value)) {
+  if (typeof value !== 'number' || isNaN(value) || !isFinite(value)) {
     return '–';
   }

📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between beb573f and 19608ee.

📒 Files selected for processing (1)

• src/dashboard/Data/Browser/FooterStats.react.js

🧰 Additional context used

🧬 Code graph analysis (1)

src/dashboard/Data/Browser/FooterStats.react.js (1)

src/components/Popover/Popover.react.js (1)

• Popover (15-98)

🪛 GitHub Check: Lint

src/dashboard/Data/Browser/FooterStats.react.js

[failure] 120-120:
'e' is defined but never used

---

[failure] 79-79:
'e' is defined but never used

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Docker linux/amd64

🔇 Additional comments (4)

src/dashboard/Data/Browser/FooterStats.react.js (4)

8-13: LGTM!

Imports and constants are appropriate for the component's functionality.

---

31-66: LGTM!

Statistical calculations are correctly implemented. Edge cases (empty arrays) are either handled by formatNumber or guarded by the parent component.

---

85-92: LGTM!

State initialization uses lazy evaluation correctly, and the hook setup is appropriate.

---

145-163: LGTM!

The render logic is clean with appropriate conditional rendering for the popover. The defensive null check provides good safety.

_{✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.}

[parseplatformorg]

🎉 This change has been released in version 8.2.0-alpha.27