refactor: Bump typescript from 5.9.3 to 6.0.2#3319
refactor: Bump typescript from 5.9.3 to 6.0.2#3319mtrezza merged 1 commit intoparse-community:alphafrom
Conversation
|
🚀 Thanks for opening this pull request! We appreciate your effort in improving the project. Please let us know once your pull request is ready for review. Tip
Note Please respond to review comments from AI agents just like you would to comments from a human reviewer. Let the reviewer resolve their own comments, unless they have reviewed and accepted your commit, or agreed with your explanation for why the feedback was incorrect. Caution Pull requests must be written using an AI agent with human supervision. Pull requests written entirely by a human will likely be rejected, because of lower code quality, higher review effort and the higher risk of introducing bugs. Please note that AI review comments on this pull request alone do not satisfy this requirement. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughBumps dev TypeScript from 5.9.3 → 6.0.2 and eslint-plugin-jest 29.15.0 → 29.15.1; adds an Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5 | ❌ 2❌ Failed checks (2 inconclusive)
✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 Checkov (3.2.513)package.json2026-04-03 19:07:25,234 [MainThread ] [ERROR] Template file not found: package.json ... [truncated 2547 characters] ... ck__) Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
package-lock.json (1)
14348-14361: Intentional TS split is appropriately isolated to dependency-analysis tooling.The root
typescript@6.0.2is separated from nestedtypescript@5.9.3instances inprecinct,dependency-tree, andfiling-cabinet. These tooling packages declare peer dependencies of^5.4.4(e.g.,detective-typescript,detective-vue2), which do not satisfy TS 6.x, making the nested isolation necessary and correct. No action required unless these tooling libraries are upgraded to declare TS 6.x compatibility.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@package-lock.json` around lines 14348 - 14361, The nested TypeScript 5.9.3 entry in package-lock.json (used by dependency packages like dependency-tree, precinct, and filing-cabinet) is intentional to isolate tooling that lists a peer dep of ^5.x and is compatible only with TS 5.x; do not remove or consolidate it into the root typescript@6.0.2 unless you update those tooling packages (detective-typescript, detective-vue2, etc.) to declare compatibility with TS 6.x—leave the nested typescript versions as-is to preserve correct peer-dependency resolution.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@package-lock.json`:
- Around line 11000-11006: The project's declared Node engine range in
package.json conflicts with a transitive dependency (eslint-visitor-keys@5.0.1)
that requires Node ^22.13.0, creating a gap for 22.12.x; update the package.json
"engines" Node range (the "engines" key) to at least ">=22.13.0 <23.0.0" to
match the transitive requirement, or alternatively add a resolutions/overrides
entry to pin eslint-visitor-keys to a version compatible with >=22.12.0 if you
must keep 22.12.x supported—make the change and regenerate lockfile so
package-lock.json no longer misstates an unsupported range.
---
Nitpick comments:
In `@package-lock.json`:
- Around line 14348-14361: The nested TypeScript 5.9.3 entry in
package-lock.json (used by dependency packages like dependency-tree, precinct,
and filing-cabinet) is intentional to isolate tooling that lists a peer dep of
^5.x and is compatible only with TS 5.x; do not remove or consolidate it into
the root typescript@6.0.2 unless you update those tooling packages
(detective-typescript, detective-vue2, etc.) to declare compatibility with TS
6.x—leave the nested typescript versions as-is to preserve correct
peer-dependency resolution.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 972338a0-5bc7-40e5-b111-00a1cd80d44d
📒 Files selected for processing (2)
package-lock.jsonpackage.json
mtrezza
force-pushed
the
refactor/typescript-6.0.2
branch
from
98f2e39 to
ad5ab5b
Compare
|
🎉 This change has been released in version 9.1.0-alpha.12 |
|
🎉 This change has been released in version 9.1.0 |
2 participants
Closes #3309
Changes
madge.typescriptoverride ($typescript) to resolve peer dependency conflict withmadge@8.0.0which declarespeerOptional: typescript@"^5.4.4"Breaking Changes
TypeScript 6.0 includes breaking changes but none affect this project's explicit configuration. The
eslint-plugin-jestco-bump resolves a peer dependency conflict with@typescript-eslint/utils.Code Changes Required
None — drop-in replacement with co-dependency bump and npm override.
Summary by CodeRabbit