Skip to content

refactor: Bump sass from 1.98.0 to 1.99.0#3333

Merged
mtrezza merged 1 commit intoparse-community:alphafrom
mtrezza:refactor/sass-1.99.0
Apr 10, 2026
Merged

refactor: Bump sass from 1.98.0 to 1.99.0#3333
mtrezza merged 1 commit intoparse-community:alphafrom
mtrezza:refactor/sass-1.99.0

Conversation

@mtrezza
Copy link
Copy Markdown
Member

@mtrezza mtrezza commented Apr 10, 2026

Closes #3321

Changes

  • Bumps sass from 1.98.0 to 1.99.0 (devDependency)
  • Adds support for parent selectors (&) at the root of the document
  • User-defined functions named calc or clamp are no longer forbidden
  • Various function name restrictions relaxed with deprecation warnings for exotic patterns
  • Full release notes: sass/dart-sass v1.99.0

Breaking Changes

  • None

Code Changes Required

  • None

Summary by CodeRabbit

  • Chores
    • Updated sass dependency to version 1.99.0

@parse-github-assistant
Copy link
Copy Markdown

🚀 Thanks for opening this pull request! We appreciate your effort in improving the project. Please let us know once your pull request is ready for review.

Tip

  • Keep pull requests small. Large PRs will be rejected. Break complex features into smaller, incremental PRs.
  • Use Test Driven Development. Write failing tests before implementing functionality. Ensure tests pass.
  • Group code into logical blocks. Add a short comment before each block to explain its purpose.
  • We offer conceptual guidance. Coding is up to you. PRs must be merge-ready for human review.
  • Our review focuses on concept, not quality. PRs with code issues will be rejected. Use an AI agent.
  • Human review time is precious. Avoid review ping-pong. Inspect and test your AI-generated code.

Note

Please respond to review comments from AI agents just like you would to comments from a human reviewer. Let the reviewer resolve their own comments, unless they have reviewed and accepted your commit, or agreed with your explanation for why the feedback was incorrect.

Caution

Pull requests must be written using an AI agent with human supervision. Pull requests written entirely by a human will likely be rejected, because of lower code quality, higher review effort and the higher risk of introducing bugs. Please note that AI review comments on this pull request alone do not satisfy this requirement. Our CI and AI review are safeguards, not development tools. If many issues are flagged, rethink your development approach. Invest more effort in planning and design rather than using review cycles to fix low-quality code.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 10, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 768703b0-6676-47d6-979e-53ca39c03bb0

📥 Commits

Reviewing files that changed from the base of the PR and between 135debb and d4829df.

📒 Files selected for processing (2)
  • package-lock.json
  • package.json

📝 Walkthrough

Walkthrough

Updated the sass package from version 1.98.0 to 1.99.0 in package.json and package-lock.json, including corresponding integrity hash and tarball URL updates in the lockfile.

Changes

Cohort / File(s) Summary
Sass Dependency Bump
package.json, package-lock.json
Version update from 1.98.0 to 1.99.0 with corresponding integrity hash and resolved package URL changes in the lockfile.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 6 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Engage In Review Feedback ❓ Inconclusive PR #3333 is a minor sass dependency bump (1.98.0 to 1.99.0) with no code changes required. While CodeRabbit provided an automated review, no substantive human reviewer feedback requiring author engagement is evident from accessible repository context. Access the GitHub PR discussion section to verify if meaningful review feedback was provided and whether the PR author engaged with reviewers through commits or discussion comments.
✅ Passed checks (6 passed)
Check name Status Explanation
Title check ✅ Passed The title begins with 'refactor:' prefix and clearly describes the main change: updating the sass dependency from version 1.98.0 to 1.99.0.
Description check ✅ Passed The PR description provides relevant change details and links to the issue, but omits the structured template sections (Issue and Approach headings).
Linked Issues check ✅ Passed The PR successfully fulfills all coding-related objectives from issue #3321: it upgrades sass from 1.98.0 to 1.99.0 with no code changes required.
Out of Scope Changes check ✅ Passed All changes are in-scope: only the sass devDependency version was updated in package.json and package-lock.json, directly addressing issue #3321.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Security Check ✅ Passed The sass devDependency update from 1.98.0 to 1.99.0 is a minor version bump with only feature additions and no security vulnerabilities introduced.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 Checkov (3.2.513)
package.json

2026-04-10 20:23:34,792 [MainThread ] [ERROR] Template file not found: package.json
2026-04-10 20:23:34,795 [MainThread ] [ERROR] Template file not found: package.json
2026-04-10 20:23:34,798 [MainThread ] [ERROR] Template file not found: package.json
2026-04-10 20:23:34,847 [MainThread ] [ERROR] Failed to invoke function /usr/local/lib/python3.11/dist-packages/checkov/common/runners/object_runner. with package.json
Traceback (most recent call last):
File "/usr/local/lib/python3.11/dist-packages/checkov/common/parallelizer/parallel_runner.py", line 88, in func_wrapper
result = original_func(item)
^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/dist-packages/checkov/common/runners/object_runner.py", line 74, in
results = parallel_runner.run_function(lambda f: (f, self._parse_file(f)), files_to_load)
^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/dist-packages/checkov/ope

... [truncated 2547 characters] ...

[MainThread ] [WARNI] Secret scanning: could not process file package.json
2026-04-10 20:23:34,898 [MainThread ] [ERROR] Exception traceback:
Traceback (most recent call last):
File "/usr/local/lib/python3.11/dist-packages/checkov/main.py", line 647, in run
self.scan_reports = runner_registry.run(
^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/dist-packages/checkov/common/runners/runner_registry.py", line 177, in run
for result in parallel_runner_results:
File "/usr/local/lib/python3.11/dist-packages/checkov/common/parallelizer/parallel_runner.py", line 118, in _run_function_multiprocess_fork
raise v.internal_exception.with_traceback(v.internal_exception.traceback)
FileNotFoundError: [Errno 2] No such file or directory: 'package.json'


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mtrezza
Copy link
Copy Markdown
Member Author

mtrezza commented Apr 10, 2026

@coderabbitai review

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 10, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@mtrezza mtrezza merged commit e8072e3 into parse-community:alpha Apr 10, 2026
11 checks passed
@mtrezza mtrezza deleted the refactor/sass-1.99.0 branch April 10, 2026 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant