Invalid response when incrementing by 1 then -1

[shehabic]

Check out this issue for an ideal bug report. The closer your issue report is to that one, the more likely we are to be able to help, and the more likely we will be to fix the issue quickly!

For implementation related questions or technical support, please refer to the Stack Overflow and Server Fault communities.

Make sure these boxes are checked before submitting your issue -- thanks for reporting issues back to Parse Server!

• You've met the prerequisites.
• You're running the latest version of Parse Server.
• You've searched through existing issues. Chances are that your issue has been reported or resolved before.

Environment Setup

I'm using the Android SDK: Latest , Parse-Server: 2.2.7

Steps to reproduce

Here's a sample request/response for the whole thing:

ParseLogInterceptor: Type : Request
ParseLogInterceptor: Request-Id : 6
ParseLogInterceptor: Url : https://my-domain/parse/mstaging/classes/ArticleMeta/3eZq60siQZ
ParseLogInterceptor: Method : PUT
ParseLogInterceptor: Headers : {X-Parse-OS-Version=6.0.1, Content-Type=application/json, X-Parse-App-Build-Version=100, X-Parse-Client-Key=MyClientKey, X-Parse-Installation-Id=ffe99909-c4d0-4ec6-9a19-b7c5b8fe6a49, X-Parse-App-Display-Version=6.0.0, X-Parse-Client-Version=a1.13.0, Content-Length=65, User-Agent=Parse Android SDK 1.13.0 (my.app.package/100) API Level 23, X-Parse-Application-Id=MyAppId}
ParseLogInterceptor: Body : {
                               "likes": {
                                   "__op": "Increment",
                                   "amount": 1
                               },
                               "objectId": "3eZq60siQZ"
                           }
ParseLogInterceptor: --------------
ParseLogInterceptor: Type : Response
ParseLogInterceptor: Request-Id : 6
ParseLogInterceptor: Status-Code : 200
ParseLogInterceptor: Reason-Phrase : OK
ParseLogInterceptor: Headers : {Access-Control-Allow-Methods=GET,PUT,POST,DELETE,OPTIONS, X-Powered-By=Express, X-Android-Selected-Protocol=http/1.1, X-Android-Response-Source=NETWORK 200, Connection=keep-alive, Access-Control-Allow-Headers=X-Parse-Master-Key, X-Parse-REST-API-Key, X-Parse-Javascript-Key, X-Parse-Application-Id, X-Parse-Client-Version, X-Parse-Session-Token, X-Requested-With, X-Parse-Revocable-Session, Content-Type, X-Android-Sent-Millis=1461091166208, Content-Type=application/json; charset=utf-8, Date=Tue, 19 Apr 2016 18:39:29 GMT, Server=nginx/1.4.6 (Ubuntu), ETag=W/"32-F+Y8ws8n9tzFsQYVwP664w", Content-Length=50, X-Android-Received-Millis=1461091166341, Access-Control-Allow-Origin=*}
ParseLogInterceptor: Body : {
                             "likes": 1,
                             "updatedAt": "2016-04-19T18:39:29.080Z"
                         }
ParseLogInterceptor: --------------
ParseLogInterceptor: Type : Request
ParseLogInterceptor: Request-Id : 7
ParseLogInterceptor: Url : https://my-domain/parse/mstaging/classes/ArticleMeta/3eZq60siQZ
ParseLogInterceptor: Method : PUT
ParseLogInterceptor: Headers : {X-Parse-OS-Version=6.0.1, Content-Type=application/json, X-Parse-App-Build-Version=100, X-Parse-Client-Key=MyClientKey, X-Parse-Installation-Id=ffe99909-c4d0-4ec6-9a19-b7c5b8fe6a49, X-Parse-App-Display-Version=6.0.0, X-Parse-Client-Version=a1.13.0, Content-Length=66, User-Agent=Parse Android SDK 1.13.0 (my.app.package/100) API Level 23, X-Parse-Application-Id=MyAppId}
ParseLogInterceptor: Body : {
                             "likes": {
                                 "__op": "Increment",
                                 "amount": -1
                             },
                             "objectId": "3eZq60siQZ"
                         }
ParseLogInterceptor: --------------
ParseLogInterceptor: Type : Response
ParseLogInterceptor: Request-Id : 7
ParseLogInterceptor: Status-Code : 200
ParseLogInterceptor: Reason-Phrase : OK
ParseLogInterceptor: Headers : {Access-Control-Allow-Methods=GET,PUT,POST,DELETE,OPTIONS, X-Powered-By=Express, X-Android-Selected-Protocol=http/1.1, X-Android-Response-Source=NETWORK 200, Connection=keep-alive, Access-Control-Allow-Headers=X-Parse-Master-Key, X-Parse-REST-API-Key, X-Parse-Javascript-Key, X-Parse-Application-Id, X-Parse-Client-Version, X-Parse-Session-Token, X-Requested-With, X-Parse-Revocable-Session, Content-Type, X-Android-Sent-Millis=1461091173342, Content-Type=application/json; charset=utf-8, Date=Tue, 19 Apr 2016 18:39:36 GMT, Server=nginx/1.4.6 (Ubuntu), ETag=W/"51-zHnFvm87UbWZjW0BSGT86w", Content-Length=81, X-Android-Received-Millis=1461091173477, Access-Control-Allow-Origin=*}
ParseLogInterceptor: Body : {
                               "likes": {
                                   "__op": "Increment",
                                   "amount": -1
                               },
                               "updatedAt": "2016-04-19T18:39:36.220Z"
                           }
ParseLogInterceptor: --------------

Logs/Trace

[shehabic]

The issue is more about the weird response that corrupts the data when I increment by -1 and the value was 1, notice that the field is defined as number.

[flovilmart]

you're expecting to get back the current value of the likes (0) I believe. Is that causing an error on Android?

[shehabic]

yes, just like the behavior of increment 1, why would the -1 be different ?

[flovilmart]

Can you give me the android stack trace?

[shehabic]

Does it really have something to do with android? shouldn't the API respond with the updated value? that's why I mainly added the full request / response here.

[flovilmart]

What's the problem with posting the stack trace of the error on Android? Yes it sound like it should behave like that, but we need to investigate deeper, you're welcome to post a PR with a fix.

[shehabic]

Well no problem with that, it's just that I don't think the issue is in the android's client, anyway here is the stack trace:

04-20 01:16:53.846 11612-11612/my.app.package E/AndroidRuntime: FATAL EXCEPTION: main Process: my.app.package, PID: 11612 java.lang.IllegalArgumentException: You cannot increment a non-number.
at com.parse.ParseIncrementOperation.apply(ParseIncrementOperation.java:60)
at com.parse.ParseObject.performOperation(ParseObject.java:2825)
at com.parse.ParseObject.increment(ParseObject.java:2909)
at com.parse.ParseObject.increment(ParseObject.java:2896)

and I'm calling this like that:

meta.getParseObject().increment("likes", -1);
meta.getParseObject().saveInBackground(new SaveCallback()  {
                @Override
                public void done(ParseException e)
                {
                    if (e != null) {
                        trackingManager.getCrashReportingInterface().reportCaughtException(e);
                    } else {
                          // the following fixes the issue as it always fetches the full data (but that's bad)
//                        meta.getParseObject().fetchInBackground();
                    }
                }
            });

[shehabic]

Further info, the response causes the object to morph from "number" to HashMap:
"likes" -> ["amount" -> "-1" , "__op" -> "Increment"]

[shehabic]

@flovilmart NodeJS is not my day-to-day lang/tech but may be if possible point me to the potential part causing this and I'll try to create a PR for it.

[flovilmart]

I'll have a look don't worry, I'm asked for the android logs to see how the SDK is interpreting that result, kinda need that to make a proper test scenario, and also understand why it may not break with other SDK's

[flovilmart]

So I just ran it with the pure REST calls, that's the result:

verbose: PUT /1/classes/AnObject/1WLpIRJsD0 { 'content-type': 'application/json',
  'x-parse-application-id': 'test',
  'x-parse-rest-api-key': 'rest',
  host: 'localhost:8378',
  accept: 'application/json',
  'content-length': '39',
  connection: 'close' } {
  "key": {
    "__op": "Increment",
    "amount": 1
  }
}
verbose: {
  "response": {
    "key": 1,
    "updatedAt": "2016-04-20T01:09:46.975Z"
  }
}
verbose: PUT /1/classes/AnObject/1WLpIRJsD0 { 'content-type': 'application/json',
  'x-parse-application-id': 'test',
  'x-parse-rest-api-key': 'rest',
  host: 'localhost:8378',
  accept: 'application/json',
  'content-length': '40',
  connection: 'close' } {
  "key": {
    "__op": "Increment",
    "amount": -1
  }
}
verbose: {
  "response": {
    "key": 0,
    "updatedAt": "2016-04-20T01:09:47.000Z"
  }
}

As you can see that seems OK. Do you have any cloud code functions running on that object?

[flovilmart]

Closing due to lack of activity, please update to latest parse-server version and reopen if the issue persist.

Don't forget to include your current:

• node version
• npm version
• parse-server version
• any relevant logs (VERBOSE=1 will enable verbose logging)