Skip to content

do not override username#1142

Merged
flovilmart merged 1 commit intomasterfrom
flovilmart.fixes1136
Mar 23, 2016
Merged

do not override username#1142
flovilmart merged 1 commit intomasterfrom
flovilmart.fixes1136

Conversation

@flovilmart
Copy link
Copy Markdown
Contributor

@flovilmart flovilmart commented Mar 23, 2016

fixes #1136

@codecov-io
Copy link
Copy Markdown

codecov-io commented Mar 23, 2016

Current coverage is 91.85%

Merging #1142 into master will not affect coverage as of 9441203

@@            master   #1142   diff @@
======================================
  Files           92      92       
  Stmts         5808    5807     -1
  Branches      1056    1056       
  Methods          0       0       
======================================
- Hit           5335    5334     -1
  Partial         11      11       
  Missed         462     462

Review entire Coverage Diff as of 9441203

Powered by Codecov. Updated on successful CI builds.

flovilmart
flovilmart reviewed Mar 23, 2016
View reviewed changes
Comment thread src/RestWrite.js
this.storage['authProvider'] = Object.keys(authData).join(',');

if (results.length == 0) {
this.data.username = cryptoUtils.newToken();
Copy link
Copy Markdown
Contributor Author

@flovilmart flovilmart Mar 23, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just needed to remove that so we don't override username when we have no results

@flovilmart flovilmart merged commit 3ce634b into master Mar 23, 2016
@flovilmart flovilmart deleted the flovilmart.fixes1136 branch March 23, 2016 11:52
@lolobosse
Copy link
Copy Markdown

lolobosse commented Mar 23, 2016

I can confirm, made it running and it solved my bug. GG @flovilmart

What is the usual time for release of such a fix?

@flovilmart
Copy link
Copy Markdown
Contributor Author

flovilmart commented Mar 23, 2016

This has been merged to master, that will go to the next release, (we just released yesterday).
Do you deploy your app remotely? on heroku? What does your folder structure look like?

@lolobosse
Copy link
Copy Markdown

lolobosse commented Mar 23, 2016

I host myself and use Parse-example basically.

To test your code, I patched (dirty) the bin folder 😆

@flovilmart
Copy link
Copy Markdown
Contributor Author

flovilmart commented Mar 23, 2016

ok good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Problem upgrading from anonymous user

4 participants

@flovilmart @codecov-io @lolobosse @drew-gross